linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Sriram Dash <sriram.dash@samsung.com>
Cc: 'Kishon Vijay Abraham I' <kishon@ti.com>,
	'Shradha Todi' <shradha.t@samsung.com>,
	bhelgaas@google.com, pankaj.dubey@samsung.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Fix NULL pointer dereference for ->get_features()
Date: Mon, 6 Jul 2020 12:17:08 +0100	[thread overview]
Message-ID: <20200706111708.GF26377@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <000001d608fb$7ab39010$701ab030$@samsung.com>

On Thu, Apr 02, 2020 at 08:01:59PM +0530, Sriram Dash wrote:

[...]

> > So the patch itself is correct though the commit log has to be fixed. You should
> > also check if all the endpoint controller drivers existing currently provides
> > epc_features.
> 
> At the moment, there is no issue for existing controller drivers as I
> can see almost all drivers are providing epc_features. But, this is
> not a mandatory feature and some controller drivers may not have
> epc_features implemented, may be in the near future.  But because we
> are dealing with the configfs, the application need not bother about
> the driver details underneath.
> 
> IMO, the code should be fixed regardless and should not cause panic in
> any case.

What's this patch status please ?

Thanks,
Lorenzo

> > Thanks
> > Kishon
> > >
> > >
> > >>  drivers/pci/endpoint/functions/pci-epf-test.c | 15 +++++++++------
> > >>  1 file changed, 9 insertions(+), 6 deletions(-)
> > >>
> > >> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c
> > >> b/drivers/pci/endpoint/functions/pci-epf-test.c
> > >> index c9121b1b9fa9..af4537a487bf 100644
> > >> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> > >> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> > >> @@ -510,14 +510,17 @@ static int pci_epf_test_bind(struct pci_epf *epf)
> > >>  		return -EINVAL;
> > >>
> > >>  	epc_features = pci_epc_get_features(epc, epf->func_no);
> > >> -	if (epc_features) {
> > >> -		linkup_notifier = epc_features->linkup_notifier;
> > >> -		msix_capable = epc_features->msix_capable;
> > >> -		msi_capable = epc_features->msi_capable;
> > >> -		test_reg_bar = pci_epc_get_first_free_bar(epc_features);
> > >> -		pci_epf_configure_bar(epf, epc_features);
> > >> +	if (!epc_features) {
> > >> +		dev_err(dev, "epc_features not implemented\n");
> > >> +		return -ENOTSUPP;
> > >>  	}
> > >>
> > >> +	linkup_notifier = epc_features->linkup_notifier;
> > >> +	msix_capable = epc_features->msix_capable;
> > >> +	msi_capable = epc_features->msi_capable;
> > >> +	test_reg_bar = pci_epc_get_first_free_bar(epc_features);
> > >> +	pci_epf_configure_bar(epf, epc_features);
> > >> +
> > >>  	epf_test->test_reg_bar = test_reg_bar;
> > >>  	epf_test->epc_features = epc_features;
> > >>
> > >> --
> > >> 2.17.1
> > >
> > >
> 

  reply	other threads:[~2020-07-06 11:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200311103443epcas5p2e97b8f3a8e52dc6f02eb551e0c97f132@epcas5p2.samsung.com>
2020-03-11 10:28 ` Shradha Todi
2020-03-19 13:36   ` Sriram Dash
2020-03-20 10:20     ` Kishon Vijay Abraham I
2020-04-02 14:31       ` Sriram Dash
2020-07-06 11:17         ` Lorenzo Pieralisi [this message]
2020-07-06 13:17           ` Sriram Dash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706111708.GF26377@e121166-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bhelgaas@google.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=pankaj.dubey@samsung.com \
    --cc=shradha.t@samsung.com \
    --cc=sriram.dash@samsung.com \
    --subject='Re: [PATCH] PCI: endpoint: Fix NULL pointer dereference for ->get_features()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).