From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B909C433DF for ; Mon, 6 Jul 2020 14:20:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD64E2070B for ; Mon, 6 Jul 2020 14:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ed6Jrprb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729257AbgGFOUz (ORCPT ); Mon, 6 Jul 2020 10:20:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729140AbgGFOUz (ORCPT ); Mon, 6 Jul 2020 10:20:55 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1968AC061794 for ; Mon, 6 Jul 2020 07:20:55 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f18so42382113wml.3 for ; Mon, 06 Jul 2020 07:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/SQQ7AOqnp0abV0mTui8yYrs1UAgtqLR05qcleZcwQE=; b=Ed6JrprbDjk8AXD6SCOI9yh0CysVyAtZO2nt/f6l1uLVAF7tPqo9QHp4648VE6/P0J iJd3+qHMbx5g2R1VjGTps0BZqc1+nkfAtJ/DC0I/fty8HyNAXW3hQewEgWXpZQsoLOZd FNf6j1vFI9bDcSZ19YcgSjidaauF0qGEx+UPTOMQVosbA7mKScWrXlbSiIyC8j4b2kTz jQxjB+VuO/AByLPP+2/rnzTx6HTicNZY68TyLXs/k9slS+eZTpkmcJvLRvAKx+JyDmwI PdzTFhyFHuxZvHNiDL4SdAdv6hIll/6VmdF8GZqofG4QIjSUW5v789VNT8yUZRQAyw7i 4C+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/SQQ7AOqnp0abV0mTui8yYrs1UAgtqLR05qcleZcwQE=; b=tEK2atE8nZKLgflxpt5v9jpshdIFdMd/OBilzJWzHMYCa5JrXYxqJ/ZeIKq6493hZb 69P1GXL/wzVf0R4QvUQLzxcWK6g+1TNCtJAM3nEFGZNYRDxOzAyiZFlxio/uVPv59r7X wTp//JgHKAqkLdn5fi4eAtGcIJlwBxbm9rBbv87msBavMyiqXGndzzLrMcUD11mhPShH 7Ujw9scdwYLHazZUGDm2Ercvfj2k8FOYNGfBFKMrLEPqVcG2VwKO8OWML8/GAAgIIXyo lCZG9I17kZrJXZEpbLImP2qaUYEdj35CapVRrH/rLcsskwY/zdatBvFeEq8KXCu9pP3M Wr/g== X-Gm-Message-State: AOAM531ozJh/Dyz9THt90SlaeV4CJla9SQyHhpQmfkOh6VkDg1DL1g27 s3u6YHYs7cHiSY5Xv8AilySVcg== X-Google-Smtp-Source: ABdhPJxttEL31vKF295CqiyvKNlNLZN2K0H1vn3bWACeSCGgEgewna0f80KeGgsIGvd6NVLZTGM+Fw== X-Received: by 2002:a1c:1fd1:: with SMTP id f200mr48281159wmf.162.1594045253749; Mon, 06 Jul 2020 07:20:53 -0700 (PDT) Received: from dell ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id x7sm24950797wrr.72.2020.07.06.07.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 07:20:53 -0700 (PDT) Date: Mon, 6 Jul 2020 15:20:51 +0100 From: Lee Jones To: Hans de Goede Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Guenter Roeck , Heikki Krogerus Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Message-ID: <20200706142051.GA3500@dell> References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-9-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jul 2020, Hans de Goede wrote: > Hi, > > On 7/6/20 3:33 PM, Lee Jones wrote: > > Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config > > configuration mechanism") pulled out the only use of 'tcpm_altmode_ops' > > last year. No need to keep it around. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] > > 1551 | static const struct typec_altmode_ops tcpm_altmode_ops = { > > | ^~~~~~~~~~~~~~~~ > > > > Cc: Guenter Roeck > > Cc: Heikki Krogerus > > Cc: Hans de Goede > > Signed-off-by: Lee Jones > > This is necessary for adding Display port over Type-C support > on devices using the tcpm code, rather then firmware, to do > the Type-C alt-mode negotiation. > > I have a local patch in my tree which adds support for this. > > But Heikki did not like my approach, so that patch > (which needs the bits you are removing) never landed > upstream: > > https://patchwork.kernel.org/patch/11199517/ > > Which is somewhat old now. Yes, that's a just a little old now. If it drags on for much longer, perhaps consider taking it out for the time being and adding it back when you start to make use of it again? > Heikki said he would look into an approach to this more to > his liking. Heikki an progress on this area? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog