[PATCH net-next 0/9] net: qed/qede: W=1 C=1 warnings cleanup

From: Alexander Lobakin <alobakin@marvell.com>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Alexander Lobakin <alobakin@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	Michal Kalderon <michal.kalderon@marvell.com>,
	"Ariel Elior" <aelior@marvell.com>,
	Denis Bolotin <denis.bolotin@marvell.com>,
	<GR-everest-linux-l2@marvell.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH net-next 0/9] net: qed/qede: W=1 C=1 warnings cleanup
Date: Mon, 6 Jul 2020 18:38:12 +0300	[thread overview]
Message-ID: <20200706153821.786-1-alobakin@marvell.com> (raw)

This set cleans qed/qede build log under W=1 C=1 with GCC 8 and
sparse 0.6.2. The only thing left is "context imbalance -- unexpected
unlock" in one of the source files, which will be issued later during
the refactoring cycles.

The biggest part is handling the endianness warnings. The current code
often just assumes that both host and device operate in LE, which is
obviously incorrect (despite the fact that it's true for x86 platforms),
and makes sparse {s,m}ad.

The rest of the series is mostly random non-functional fixes
here-and-there.

Alexander Lobakin (9):
  net: qed: move static iro_arr[] out of header file
  net: qed: cleanup global structs declarations
  net: qed: correct qed_hw_err_notify() prototype
  net: qed: address kernel-doc warnings
  net: qed: improve indentation of some parts of code
  net: qed: use ptr shortcuts to dedup field accessing in some parts
  net: qed: sanitize BE/LE data processing
  net: qede: fix kernel-doc for qede_ptp_adjfreq()
  net: qede: fix BE vs CPU comparison

 drivers/net/ethernet/qlogic/qed/qed_cxt.c     |  14 +-
 drivers/net/ethernet/qlogic/qed/qed_dcbx.c    |  27 +-
 drivers/net/ethernet/qlogic/qed/qed_dcbx.h    |   2 +
 drivers/net/ethernet/qlogic/qed/qed_debug.c   |  52 ++--
 drivers/net/ethernet/qlogic/qed/qed_fcoe.c    |  54 ++--
 drivers/net/ethernet/qlogic/qed/qed_fcoe.h    |   5 -
 drivers/net/ethernet/qlogic/qed/qed_hsi.h     | 267 +++++++-----------
 drivers/net/ethernet/qlogic/qed/qed_hw.c      |   5 +-
 drivers/net/ethernet/qlogic/qed/qed_hw.h      |   7 +-
 .../ethernet/qlogic/qed/qed_init_fw_funcs.c   | 128 +++++----
 .../net/ethernet/qlogic/qed/qed_init_ops.c    |  73 +++++
 drivers/net/ethernet/qlogic/qed/qed_int.c     | 123 ++++----
 drivers/net/ethernet/qlogic/qed/qed_iscsi.c   |  48 ++--
 drivers/net/ethernet/qlogic/qed/qed_iscsi.h   |   4 -
 drivers/net/ethernet/qlogic/qed/qed_iwarp.c   | 150 ++++++----
 drivers/net/ethernet/qlogic/qed/qed_l2.c      |  81 +++---
 drivers/net/ethernet/qlogic/qed/qed_ll2.c     |   9 +-
 drivers/net/ethernet/qlogic/qed/qed_ll2.h     |   2 +
 drivers/net/ethernet/qlogic/qed/qed_main.c    |  16 +-
 drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c |   4 +-
 drivers/net/ethernet/qlogic/qed/qed_ptp.c     |   1 +
 drivers/net/ethernet/qlogic/qed/qed_ptp.h     |   9 +
 drivers/net/ethernet/qlogic/qed/qed_rdma.c    |  52 ++--
 drivers/net/ethernet/qlogic/qed/qed_rdma.h    |   2 +-
 drivers/net/ethernet/qlogic/qed/qed_roce.c    | 203 ++++++-------
 drivers/net/ethernet/qlogic/qed/qed_sp.h      |   9 +-
 .../net/ethernet/qlogic/qed/qed_sp_commands.c |  24 +-
 drivers/net/ethernet/qlogic/qed/qed_spq.c     |  16 +-
 drivers/net/ethernet/qlogic/qed/qed_sriov.c   |  27 +-
 drivers/net/ethernet/qlogic/qed/qed_sriov.h   |   2 +
 .../net/ethernet/qlogic/qede/qede_filter.c    |   8 +-
 drivers/net/ethernet/qlogic/qede/qede_ptp.c   |  10 +-
 include/linux/qed/qed_if.h                    |  15 +-
 33 files changed, 743 insertions(+), 706 deletions(-)
 create mode 100644 drivers/net/ethernet/qlogic/qed/qed_ptp.h

-- 
2.25.1