From: kernel test robot <lkp@intel.com>
To: Mike Tipton <mdtipton@codeaurora.org>, georgi.djakov@linaro.org
Cc: kbuild-all@lists.01.org, bjorn.andersson@linaro.org,
agross@kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Tipton <mdtipton@codeaurora.org>
Subject: Re: [PATCH 4/4] interconnect: qcom: Fix small BW votes being truncated to zero
Date: Tue, 7 Jul 2020 00:45:30 +0800 [thread overview]
Message-ID: <202007070032.9K4Y33EZ%lkp@intel.com> (raw)
In-Reply-To: <20200623040814.23791-5-mdtipton@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 4051 bytes --]
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.8-rc4 next-20200706]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Tipton/interconnect-qcom-Misc-bcm-voter-changes-and-fixes/20200623-121301
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd0d718152e4c65b173070d48ea9dfc06894c3e5
config: arm64-randconfig-s032-20200706 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-14-g8fce3d7a-dirty
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/interconnect/qcom/bcm-voter.c:79:77: sparse: sparse: restricted __le16 degrades to integer
drivers/interconnect/qcom/bcm-voter.c:83:78: sparse: sparse: restricted __le16 degrades to integer
>> drivers/interconnect/qcom/bcm-voter.c:89:66: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned long long [usertype] base @@ got restricted __le32 [usertype] unit @@
>> drivers/interconnect/qcom/bcm-voter.c:89:66: sparse: expected unsigned long long [usertype] base
drivers/interconnect/qcom/bcm-voter.c:89:66: sparse: got restricted __le32 [usertype] unit
drivers/interconnect/qcom/bcm-voter.c:92:66: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned long long [usertype] base @@ got restricted __le32 [usertype] unit @@
drivers/interconnect/qcom/bcm-voter.c:92:66: sparse: expected unsigned long long [usertype] base
drivers/interconnect/qcom/bcm-voter.c:92:66: sparse: got restricted __le32 [usertype] unit
drivers/interconnect/qcom/bcm-voter.c:124:21: sparse: sparse: restricted __le32 degrades to integer
drivers/interconnect/qcom/bcm-voter.c:124:21: sparse: sparse: restricted __le32 degrades to integer
vim +89 drivers/interconnect/qcom/bcm-voter.c
67
68 static void bcm_aggregate(struct qcom_icc_bcm *bcm)
69 {
70 struct qcom_icc_node *node;
71 size_t i, bucket;
72 u64 agg_avg[QCOM_ICC_NUM_BUCKETS] = {0};
73 u64 agg_peak[QCOM_ICC_NUM_BUCKETS] = {0};
74 u64 temp;
75
76 for (bucket = 0; bucket < QCOM_ICC_NUM_BUCKETS; bucket++) {
77 for (i = 0; i < bcm->num_nodes; i++) {
78 node = bcm->nodes[i];
79 temp = bcm_div(node->sum_avg[bucket] * bcm->aux_data.width,
80 node->buswidth * node->channels);
81 agg_avg[bucket] = max(agg_avg[bucket], temp);
82
83 temp = bcm_div(node->max_peak[bucket] * bcm->aux_data.width,
84 node->buswidth);
85 agg_peak[bucket] = max(agg_peak[bucket], temp);
86 }
87
88 temp = agg_avg[bucket] * bcm->vote_scale;
> 89 bcm->vote_x[bucket] = bcm_div(temp, bcm->aux_data.unit);
90
91 temp = agg_peak[bucket] * bcm->vote_scale;
92 bcm->vote_y[bucket] = bcm_div(temp, bcm->aux_data.unit);
93 }
94
95 if (bcm->keepalive && bcm->vote_x[QCOM_ICC_BUCKET_AMC] == 0 &&
96 bcm->vote_y[QCOM_ICC_BUCKET_AMC] == 0) {
97 bcm->vote_x[QCOM_ICC_BUCKET_AMC] = 1;
98 bcm->vote_x[QCOM_ICC_BUCKET_WAKE] = 1;
99 bcm->vote_y[QCOM_ICC_BUCKET_AMC] = 1;
100 bcm->vote_y[QCOM_ICC_BUCKET_WAKE] = 1;
101 }
102 }
103
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37856 bytes --]
prev parent reply other threads:[~2020-07-06 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 4:08 [PATCH 0/4] interconnect: qcom: Misc bcm-voter changes and fixes Mike Tipton
2020-06-23 4:08 ` [PATCH 1/4] interconnect: qcom: Support bcm-voter-specific TCS wait behavior Mike Tipton
2020-07-02 9:02 ` Georgi Djakov
2020-07-02 21:01 ` Mike Tipton
2020-06-23 4:08 ` [PATCH 2/4] interconnect: qcom: Only wait for completion in AMC/WAKE by default Mike Tipton
2020-06-23 4:08 ` [PATCH 3/4] interconnect: qcom: Add support for per-BCM scaling factors Mike Tipton
2020-06-23 4:08 ` [PATCH 4/4] interconnect: qcom: Fix small BW votes being truncated to zero Mike Tipton
2020-07-02 11:11 ` Georgi Djakov
2020-07-02 21:02 ` Mike Tipton
2020-07-06 16:45 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007070032.9K4Y33EZ%lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mdtipton@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).