From: Muchun Song <songmuchun@bytedance.com>
To: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
shakeelb@google.com, Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH v5.4.y, v4.19.y] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy
Date: Tue, 7 Jul 2020 14:27:54 +0800 [thread overview]
Message-ID: <20200707062754.8383-1-songmuchun@bytedance.com> (raw)
If the kmem_cache refcount is greater than one, we should not
mark the root kmem_cache as dying. If we mark the root kmem_cache
dying incorrectly, the non-root kmem_cache can never be destroyed.
It resulted in memory leak when memcg was destroyed. We can use the
following steps to reproduce.
1) Use kmem_cache_create() to create a new kmem_cache named A.
2) Coincidentally, the kmem_cache A is an alias for kmem_cache B,
so the refcount of B is just increased.
3) Use kmem_cache_destroy() to destroy the kmem_cache A, just
decrease the B's refcount but mark the B as dying.
4) Create a new memory cgroup and alloc memory from the kmem_cache
A. It leads to create a non-root kmem_cache for allocating.
5) When destroy the memory cgroup created in the step 4), the
non-root kmem_cache can never be destroyed.
If we repeat steps 4) and 5), this will cause a lot of memory leak.
So only when refcount reach zero, we mark the root kmem_cache as dying.
Fixes: 92ee383f6daa ("mm: fix race between kmem_cache destroy, create and deactivate")
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
mm/slab_common.c | 43 +++++++++++++++++++++++++++++++++++++++++--
1 file changed, 41 insertions(+), 2 deletions(-)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 8c1ffbf7de45..83ee6211aec7 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -258,6 +258,11 @@ static void memcg_unlink_cache(struct kmem_cache *s)
list_del(&s->memcg_params.kmem_caches_node);
}
}
+
+static inline bool memcg_kmem_cache_dying(struct kmem_cache *s)
+{
+ return is_root_cache(s) && s->memcg_params.dying;
+}
#else
static inline int init_memcg_params(struct kmem_cache *s,
struct kmem_cache *root_cache)
@@ -272,6 +277,11 @@ static inline void destroy_memcg_params(struct kmem_cache *s)
static inline void memcg_unlink_cache(struct kmem_cache *s)
{
}
+
+static inline bool memcg_kmem_cache_dying(struct kmem_cache *s)
+{
+ return false;
+}
#endif /* CONFIG_MEMCG_KMEM */
/*
@@ -326,6 +336,13 @@ int slab_unmergeable(struct kmem_cache *s)
if (s->refcount < 0)
return 1;
+ /*
+ * If the kmem_cache is dying. We should also skip this
+ * kmem_cache.
+ */
+ if (memcg_kmem_cache_dying(s))
+ return 1;
+
return 0;
}
@@ -944,8 +961,6 @@ void kmem_cache_destroy(struct kmem_cache *s)
if (unlikely(!s))
return;
- flush_memcg_workqueue(s);
-
get_online_cpus();
get_online_mems();
@@ -955,6 +970,30 @@ void kmem_cache_destroy(struct kmem_cache *s)
if (s->refcount)
goto out_unlock;
+#ifdef CONFIG_MEMCG_KMEM
+ mutex_unlock(&slab_mutex);
+
+ put_online_mems();
+ put_online_cpus();
+
+ flush_memcg_workqueue(s);
+
+ get_online_cpus();
+ get_online_mems();
+
+ mutex_lock(&slab_mutex);
+
+ if (WARN(s->refcount,
+ "kmem_cache_destroy %s: Slab cache is still referenced\n",
+ s->name)) {
+ /*
+ * Reset the dying flag setted by flush_memcg_workqueue().
+ */
+ s->memcg_params.dying = false;
+ goto out_unlock;
+ }
+#endif
+
err = shutdown_memcg_caches(s);
if (!err)
err = shutdown_cache(s);
--
2.11.0
next reply other threads:[~2020-07-07 6:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 6:27 Muchun Song [this message]
2020-07-15 11:32 ` [PATCH v5.4.y, v4.19.y] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy Vlastimil Babka
2020-07-15 15:13 ` [External] " Muchun Song
2020-07-15 15:43 ` Vlastimil Babka
2020-07-15 15:55 ` Muchun Song
2020-07-15 16:24 ` Roman Gushchin
2020-07-15 16:31 ` [External] " Muchun Song
2020-07-15 15:20 ` Shakeel Butt
2020-07-15 15:28 ` [External] " Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707062754.8383-1-songmuchun@bytedance.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).