From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1531C433E1 for ; Tue, 7 Jul 2020 21:32:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0F19206BE for ; Tue, 7 Jul 2020 21:32:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W4FLApme" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729422AbgGGVcQ (ORCPT ); Tue, 7 Jul 2020 17:32:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728502AbgGGVcP (ORCPT ); Tue, 7 Jul 2020 17:32:15 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A254C08C5DC for ; Tue, 7 Jul 2020 14:32:15 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id z5so20602936pgb.6 for ; Tue, 07 Jul 2020 14:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7RZJvmavIn0O2TKntqB9QMi92acXLHjQQiD6TqtsJM8=; b=W4FLApmeUSAjzZei1tcFaAdYwlotTF70I4pqSAQG7rO5K1XEga+KnzxWnE/bCLq90N sQjhKVPREYroxBtzQItv//t58RkmCbDUYk9mS899tJrQuouZKBGKic5p/HdASJzraak6 LSXz9O0gsIm+1nPah9eL7XgYtEJsFnRYWVq34= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7RZJvmavIn0O2TKntqB9QMi92acXLHjQQiD6TqtsJM8=; b=P7HYjr2fKAY8noOpGe6sNHfOWjnT7qLbcfqm+8B9uPoQFYFmYtVwUZJKMtLaP2Bj6i wPFaqEj9DBtH2NY4YuLK8Yzuy1KueY5YJ6yGKuKor2epakJ7sgOkbD+8DpdQ/Aoj6s1C 26zgg1BQVDCbd7QljK5C/2K279BEZkcozlS/Kx+R9/WyuhdPDFpfP4yvbJvFoyZ8BFUb iPguzBc3U/X6Hm4FpkS5Fr8t0OK88MURhS9PBr6V3i2MO6AN/n5cnINdjttOP59e2l6m ivGBi3ix9o4CLgwJLLGfjRdQZ5AHrCzYg65suD+DoHEiHfdwX0uFvRXTNaf8ZDPtYxov Rv2A== X-Gm-Message-State: AOAM533qEqh28BrWJ0bFYQGeaQ9G/dU+VBI4rVD68SsDvCVbJcLoL5YY n/xjhVx9Tx+qmowSoerv30S3KQ== X-Google-Smtp-Source: ABdhPJyjWOYHT6AfI1WRr7cur6K+X6jRbh3iIvEo/GyqoEveZ4YQtxGCntbWjkIu+/Fdy5u9itfeOA== X-Received: by 2002:a63:3d07:: with SMTP id k7mr46650708pga.93.1594157534774; Tue, 07 Jul 2020 14:32:14 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ji2sm3301357pjb.1.2020.07.07.14.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 14:32:13 -0700 (PDT) Date: Tue, 7 Jul 2020 14:32:12 -0700 From: Kees Cook To: Borislav Petkov , Thomas Gleixner , x86@kernel.org Cc: Nick Terrell , linux-kernel@vger.kernel.org, Chris Mason , linux-kbuild@vger.kernel.org, gregkh@linuxfoundation.org, Petr Malat , Kernel Team , Adam Borowski , Patrick Williams , rmikey@fb.com, mingo@kernel.org, Patrick Williams , Sedat Dilek , Norbert Lange , Andrew Morton , Nick Terrell Subject: Re: [GIT PULL][PATCH v6 0/8] Add support for ZSTD-compressed kernel and initramfs Message-ID: <202007071422.1060F5932@keescook> References: <20200707034604.1539157-1-nickrterrell@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707034604.1539157-1-nickrterrell@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2020 at 08:45:56PM -0700, Nick Terrell wrote: > From: Nick Terrell > > Please pull from > > git@github.com:terrelln/linux.git tags/v6-zstd > > to get these changes. Alternatively the patchset is included. > > Hi all, > > This patch set adds support for a ZSTD-compressed kernel, ramdisk, and > initramfs in the kernel boot process. ZSTD-compressed ramdisk and initramfs > are supported on all architectures. The ZSTD-compressed kernel is only > hooked up to x86 in this patch set. Hello x86 maintainers! I think this series is ready to go. Notes below... > [...] > x86: bump ZO_z_extra_bytes margin for zstd The above patch is really the only thing that has any external visibility to kernels that have ZSTD disabled. Given the ratios of memory sizes involved (an extra 64K when we're dealing with 2MB windows) seems reasonable to me. If that isn't acceptable, it should be trivial to make it CONFIG-selectable (like we already do with BOOT_HEAP_SIZE). What do you think? If the non-x86 parts should land first in -mm, I guess that would be okay, but I think it makes sense for all of this to go via -tip. -Kees -- Kees Cook