From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4850C433DF for ; Tue, 7 Jul 2020 15:32:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B33020663 for ; Tue, 7 Jul 2020 15:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135962; bh=aWpgFlCBzK5h+/+1sHuWwv/hk8yVyQu8bgqP+H5I9mQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AFTp5SkRZhTOmF98oXfWMnP6fkNBkpHaIAlrZEkbU5Kn+qB1N5vDBewG43U19/rTG SynpyYxsJRVrgYT7lU+u/F8FywdJyvJXKkPS13XQIHL7BaU/RjUEuOXmuDIL27LJa5 BlXAwJLkwZuGeoB/9GG1jkdgvbCCoImmuWrDuZIo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729986AbgGGPcl (ORCPT ); Tue, 7 Jul 2020 11:32:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:34236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729145AbgGGPVy (ORCPT ); Tue, 7 Jul 2020 11:21:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC8032065D; Tue, 7 Jul 2020 15:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135314; bh=aWpgFlCBzK5h+/+1sHuWwv/hk8yVyQu8bgqP+H5I9mQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TVV6JmpM6MyeIeWsEE276z06XvSXwwRaUkkqz5JmosPcN7btzlFWxlFv0VYUwpK/L ptCjcH7QG/Z8Zj3x5giJIgFO1G2X6DzVtRUNSugdATcMXJK9v9g9KNIR5UUiwo4XBR luJfBRjR+RGNWmvkL2P/ZHyxq8AZkeBevJ5KVftg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nirmoy Das , Alex Deucher Subject: [PATCH 5.4 57/65] drm/amdgpu: use %u rather than %d for sclk/mclk Date: Tue, 7 Jul 2020 17:17:36 +0200 Message-Id: <20200707145755.215913352@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145752.417212219@linuxfoundation.org> References: <20200707145752.417212219@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Deucher commit beaf10efca64ac824240838ab1f054dfbefab5e6 upstream. Large clock values may overflow and show up as negative. Reported by prOMiNd on IRC. Acked-by: Nirmoy Das Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c @@ -2101,7 +2101,7 @@ static ssize_t amdgpu_hwmon_show_sclk(st if (r) return r; - return snprintf(buf, PAGE_SIZE, "%d\n", sclk * 10 * 1000); + return snprintf(buf, PAGE_SIZE, "%u\n", sclk * 10 * 1000); } static ssize_t amdgpu_hwmon_show_sclk_label(struct device *dev, @@ -2131,7 +2131,7 @@ static ssize_t amdgpu_hwmon_show_mclk(st if (r) return r; - return snprintf(buf, PAGE_SIZE, "%d\n", mclk * 10 * 1000); + return snprintf(buf, PAGE_SIZE, "%u\n", mclk * 10 * 1000); } static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,