* [PATCH] mm: vmalloc: remove redundant asignmnet in unmap_kernel_range_noflush()
@ 2020-07-07 16:32 Mike Rapoport
2020-07-07 17:16 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Mike Rapoport @ 2020-07-07 16:32 UTC (permalink / raw)
To: Andrew Morton
Cc: Joerg Roedel, Mike Rapoport, linux-mm, linux-kernel, Mike Rapoport
From: Mike Rapoport <rppt@linux.ibm.com>
'addr' is set to 'start' and then a few lines afterwards 'start' is
set to 'addr'.
Remove the second asignment.
Fixes: 2ba3e6947aed ("mm/vmalloc: track which page-table levels were modified")
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
mm/vmalloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 5a2b55c8dd9a..68ebbafc9c9b 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -171,11 +171,10 @@ void unmap_kernel_range_noflush(unsigned long start, unsigned long size)
pgd_t *pgd;
unsigned long addr = start;
pgtbl_mod_mask mask = 0;
BUG_ON(addr >= end);
- start = addr;
pgd = pgd_offset_k(addr);
do {
next = pgd_addr_end(addr, end);
if (pgd_bad(*pgd))
mask |= PGTBL_PGD_MODIFIED;
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: vmalloc: remove redundant asignmnet in unmap_kernel_range_noflush()
2020-07-07 16:32 [PATCH] mm: vmalloc: remove redundant asignmnet in unmap_kernel_range_noflush() Mike Rapoport
@ 2020-07-07 17:16 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2020-07-07 17:16 UTC (permalink / raw)
To: Mike Rapoport, Andrew Morton
Cc: Joerg Roedel, linux-mm, linux-kernel, Mike Rapoport
On 07.07.20 18:32, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> 'addr' is set to 'start' and then a few lines afterwards 'start' is
> set to 'addr'.
> Remove the second asignment.
>
> Fixes: 2ba3e6947aed ("mm/vmalloc: track which page-table levels were modified")
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> mm/vmalloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 5a2b55c8dd9a..68ebbafc9c9b 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -171,11 +171,10 @@ void unmap_kernel_range_noflush(unsigned long start, unsigned long size)
> pgd_t *pgd;
> unsigned long addr = start;
> pgtbl_mod_mask mask = 0;
>
> BUG_ON(addr >= end);
> - start = addr;
> pgd = pgd_offset_k(addr);
> do {
> next = pgd_addr_end(addr, end);
> if (pgd_bad(*pgd))
> mask |= PGTBL_PGD_MODIFIED;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-07 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 16:32 [PATCH] mm: vmalloc: remove redundant asignmnet in unmap_kernel_range_noflush() Mike Rapoport
2020-07-07 17:16 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).