From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FDDC433E0 for ; Tue, 7 Jul 2020 19:23:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75EA72065D for ; Tue, 7 Jul 2020 19:23:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbgGGTXb (ORCPT ); Tue, 7 Jul 2020 15:23:31 -0400 Received: from mga12.intel.com ([192.55.52.136]:41456 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728036AbgGGTX2 (ORCPT ); Tue, 7 Jul 2020 15:23:28 -0400 IronPort-SDR: hQ/IiaxezlUf8mpQTHXhPz6KHh6VMVNOdq7NveNVwDGkmybYQPnLGkXaXP+DTVQQcSKt3Ubmcb Rxg/lTAjQ2YA== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="127277729" X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="127277729" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:28 -0700 IronPort-SDR: SXk1Q10/dEw/B/Ix8SBzmmQ/EaXgCGiyRZzY/KFVwafU5RV1QwarZfIx8N5njtxEpEbarCmYED AVEqznV6nxUQ== X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="266915974" Received: from mrtorger-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.254.77.62]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:26 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, Lee Jones , Pierre-Louis Bossart , Jerome Brunet , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Kevin Hilman , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] ASoC: meson: axg-pdm: remove comparison always false warning Date: Tue, 7 Jul 2020 14:23:09 -0500 Message-Id: <20200707192310.98663-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> References: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix W=1 warning. sound/soc/meson/axg-pdm.c: In function ‘axg_pdm_set_channel_mask’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] cast the channel number to an int to avoid checking if an unsigned value is lower than zero. Signed-off-by: Pierre-Louis Bossart --- sound/soc/meson/axg-pdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/meson/axg-pdm.c b/sound/soc/meson/axg-pdm.c index bfd37d49a73e..8fe5b2563619 100644 --- a/sound/soc/meson/axg-pdm.c +++ b/sound/soc/meson/axg-pdm.c @@ -206,7 +206,7 @@ static int axg_pdm_set_sample_pointer(struct axg_pdm *priv) static void axg_pdm_set_channel_mask(struct axg_pdm *priv, unsigned int channels) { - unsigned int mask = GENMASK(channels - 1, 0); + unsigned int mask = GENMASK((int)channels - 1, 0); /* Put all channel in reset */ regmap_update_bits(priv->map, PDM_CTRL, -- 2.25.1