From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel-team@android.com
Subject: Re: [PATCH v10 4/4] ext4: Use generic casefolding support
Date: Tue, 7 Jul 2020 18:44:39 -0700 [thread overview]
Message-ID: <20200708014439.GH839@sol.localdomain> (raw)
In-Reply-To: <20200707113123.3429337-5-drosen@google.com>
On Tue, Jul 07, 2020 at 04:31:23AM -0700, Daniel Rosenberg wrote:
> This switches ext4 over to the generic support provided in
> the previous patch.
>
> Since casefolded dentries behave the same in ext4 and f2fs, we decrease
> the maintenance burden by unifying them, and any optimizations will
> immediately apply to both.
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
> ---
> fs/ext4/dir.c | 64 ++-----------------------------------------------
> fs/ext4/ext4.h | 12 ----------
> fs/ext4/hash.c | 2 +-
> fs/ext4/namei.c | 20 +++++++---------
> fs/ext4/super.c | 12 +++++-----
> 5 files changed, 17 insertions(+), 93 deletions(-)
>
Looks good, you can add:
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
prev parent reply other threads:[~2020-07-08 1:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 11:31 [PATCH v10 0/4] Prepare for upcoming Casefolding/Encryption patches Daniel Rosenberg
2020-07-07 11:31 ` [PATCH v10 1/4] unicode: Add utf8_casefold_hash Daniel Rosenberg
2020-07-07 17:50 ` Gabriel Krisman Bertazi
2020-07-08 1:36 ` Eric Biggers
2020-07-07 11:31 ` [PATCH v10 2/4] fs: Add standard casefolding support Daniel Rosenberg
2020-07-08 1:27 ` Eric Biggers
2020-07-07 11:31 ` [PATCH v10 3/4] f2fs: Use generic " Daniel Rosenberg
2020-07-08 1:41 ` Eric Biggers
2020-07-07 11:31 ` [PATCH v10 4/4] ext4: " Daniel Rosenberg
2020-07-08 1:44 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708014439.GH839@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).