From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>,
mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] tracing: toplevel d_entry already initialized
Date: Fri, 10 Jul 2020 09:11:19 +0800 [thread overview]
Message-ID: <20200710011119.GB51939@L-31X9LVDL-1304.local> (raw)
In-Reply-To: <20200709181359.42b4e61e@oasis.local.home>
On Thu, Jul 09, 2020 at 06:13:59PM -0400, Steven Rostedt wrote:
>On Fri, 3 Jul 2020 10:06:12 +0800
>Wei Yang <richard.weiyang@linux.alibaba.com> wrote:
>
>> Currently we have following call flow:
>>
>> tracer_init_tracefs()
>> tracing_init_dentry()
>> event_trace_init()
>> tracing_init_dentry()
>>
>> This shows tracing_init_dentry() is called twice in this flow and this
>> is not necessary.
>
>There's no reason to have patch 4 and 5 separate. Fold the two together.
>
Yep, if you think there is no need.
Do you want me to send v2 based on you comments?
>If you want, you can create another patch that changes
>tracing_init_dentry() to return a integer, as you point out, it never
>returns an actual dentry. No reason for having it return a pointer then.
>
>-- Steve
>
>
>>
>> Let's remove the second one when it is for sure be properly initialized.
>>
>> Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
>> ---
>> kernel/trace/trace_events.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
>> index 8b3aa57dcea6..76879b29cf33 100644
>> --- a/kernel/trace/trace_events.c
>> +++ b/kernel/trace/trace_events.c
>> @@ -3434,7 +3434,6 @@ early_initcall(event_trace_enable_again);
>> __init int event_trace_init(void)
>> {
>> struct trace_array *tr;
>> - struct dentry *d_tracer;
>> struct dentry *entry;
>> int ret;
>>
>> @@ -3442,10 +3441,6 @@ __init int event_trace_init(void)
>> if (!tr)
>> return -ENODEV;
>>
>> - d_tracer = tracing_init_dentry();
>> - if (IS_ERR(d_tracer))
>> - return 0;
>> -
>> entry = tracefs_create_file("available_events", 0444, NULL,
>> tr, &ftrace_avail_fops);
>> if (!entry)
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-07-10 1:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 2:06 [PATCH 1/5] tracing: use union to simplify the trace_event_functions initialization Wei Yang
2020-07-03 2:06 ` [PATCH 2/5] tracing: simplify the logic by defining next to be "lasst + 1" Wei Yang
2020-07-09 21:59 ` Steven Rostedt
2020-07-03 2:06 ` [PATCH 3/5] tracing: save one trace_event->type by using __TRACE_LAST_TYPE Wei Yang
2020-07-09 22:04 ` Steven Rostedt
2020-07-03 2:06 ` [PATCH 4/5] tracing: use NULL directly to create root level tracefs Wei Yang
2020-07-03 2:06 ` [PATCH 5/5] tracing: toplevel d_entry already initialized Wei Yang
2020-07-09 22:13 ` Steven Rostedt
2020-07-10 1:11 ` Wei Yang [this message]
2020-07-10 13:08 ` Steven Rostedt
2020-07-09 21:57 ` [PATCH 1/5] tracing: use union to simplify the trace_event_functions initialization Steven Rostedt
2020-07-10 1:10 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710011119.GB51939@L-31X9LVDL-1304.local \
--to=richard.weiyang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).