From: Matthew Wilcox <willy@infradead.org>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@suse.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 1/1] mm/vmalloc.c: Add an error message if two areas overlap
Date: Fri, 10 Jul 2020 21:01:38 +0100 [thread overview]
Message-ID: <20200710200138.GQ12769@casper.infradead.org> (raw)
In-Reply-To: <20200710200030.GB19487@pc636>
On Fri, Jul 10, 2020 at 10:00:30PM +0200, Uladzislau Rezki wrote:
> On Fri, Jul 10, 2020 at 08:44:06PM +0100, Matthew Wilcox wrote:
> > On Fri, Jul 10, 2020 at 09:40:42PM +0200, Uladzislau Rezki (Sony) wrote:
> > > Before triggering a BUG() it would be useful to understand
> > > how two areas overlap between each other. Print information
> > > about start/end addresses of both VAs and their addresses.
> > >
> > > For example if both are identical it could mean double free.
> > >
> > > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> > > ---
> > > mm/vmalloc.c | 10 +++++++++-
> > > 1 file changed, 9 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> > > index 5a2b55c8dd9a..1679b01febcd 100644
> > > --- a/mm/vmalloc.c
> > > +++ b/mm/vmalloc.c
> > > @@ -549,8 +549,13 @@ find_va_links(struct vmap_area *va,
> > > else if (va->va_end > tmp_va->va_start &&
> > > va->va_start >= tmp_va->va_end)
> > > link = &(*link)->rb_right;
> > > - else
> > > + else {
> > > + pr_err("Overlaps: 0x%px(0x%lx-0x%lx), 0x%px(0x%lx-0x%lx)\n",
> > > + va, va->va_start, va->va_end, tmp_va,
> > > + tmp_va->va_start, tmp_va->va_end);
> >
> > It might be helpful to have a "vmalloc:" prefix to that string to indicate
> > where to start searching. And I don't think we're supposed to use %px
> > without a really good justification these days.
> >
> That makes sense, i will add such prefix for sure. As for %px i can just
> use a casting to (unsigned long) and 0x%lx prefix.
That's not the point. Linus wants us to not display actual pointers to
the user.
next prev parent reply other threads:[~2020-07-10 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 19:40 [PATCH 1/1] mm/vmalloc.c: Add an error message if two areas overlap Uladzislau Rezki (Sony)
2020-07-10 19:44 ` Uladzislau Rezki
2020-07-10 19:44 ` Matthew Wilcox
2020-07-10 19:45 ` Uladzislau Rezki
2020-07-10 20:00 ` Uladzislau Rezki
2020-07-10 20:01 ` Matthew Wilcox [this message]
2020-07-10 20:04 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710200138.GQ12769@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).