From: Douglas Anderson <dianders@chromium.org>
To: Rob Herring <robh+dt@kernel.org>, Rob Clark <robdclark@gmail.com>,
Sean Paul <sean@poorly.run>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting
Date: Fri, 10 Jul 2020 16:02:15 -0700 [thread overview]
Message-ID: <20200710230224.2265647-1-dianders@chromium.org> (raw)
I found that if I ever had a little mistake in my kernel config,
or device tree, or graphics driver that my system would sit in a loop
at bootup trying again and again and again. An example log was:
msm ae00000.mdss: bound ae01000.mdp (ops 0xffffffe596e951f8)
msm_dsi ae94000.dsi: ae94000.dsi supply gdsc not found, using dummy regulator
msm_dsi_manager_register: failed to register mipi dsi host for DSI 0
[drm:ti_sn_bridge_probe] *ERROR* could not find any panel node
...
I finally tracked it down where this was happening:
- msm_pdev_probe() is called.
- msm_pdev_probe() registers drivers. Registering drivers kicks
off processing of probe deferrals.
- component_master_add_with_match() could return -EPROBE_DEFER.
making msm_pdev_probe() return -EPROBE_DEFER.
- When msm_pdev_probe() returned the processing of probe deferrals
happens.
- Loop back to the start.
It looks like we can fix this by marking "mdss" as a "simple-bus".
I have no idea if people consider this the right thing to do or a
hack. Hopefully it's the right thing to do. :-)
Once I do this I notice that my boot gets marginally faster (you
don't need to probe the sub devices over and over) and also if I
have a problem it doesn't loop forever (on my system it still
gets upset about some stuck clocks in that case, but at least I
can boot up).
Unless someone hates this, I'd expect:
- Get Rob H to say that the bindings are OK (if they are) and yell
that these really need to be converted to yaml (they do).
- Get Sean or Rob C to land the bindings and driver patch.
- Get Andy or Bjorn to land the dts bits.
NOTES:
- The first patch could land either way. It's just a cleanup.
- I tried to split the dts files into separate patches to ease
backporting if desired. Also because I can't actually test most
of this hardware myself.
Douglas Anderson (9):
drm/msm: Use the devm variant of of_platform_populate()
dt-bindings: msm/dpu: Add simple-bus to dpu bindings
dt-bindings: msm/mdp5: Add simple-bus to dpu bindings
drm/msm: Avoid manually populating our children if "simple-bus" is
there
arm64: dts: qcom: sc7180: Add "simple-bus" to our mdss node
arm64: dts: qcom: sdm845: Add "simple-bus" to our mdss node
arm64: dts: qcom: msm8916: Add "simple-bus" to our mdss node
arm64: dts: qcom: msm8996: Add "simple-bus" to our mdss node
ARM: dts: qcom: msm8974: Add "simple-bus" to our mdss node
.../devicetree/bindings/display/msm/dpu.txt | 4 ++-
.../devicetree/bindings/display/msm/mdp5.txt | 2 +-
arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
drivers/gpu/drm/msm/msm_drv.c | 34 ++++++++-----------
8 files changed, 24 insertions(+), 26 deletions(-)
--
2.27.0.383.g050319c2ae-goog
next reply other threads:[~2020-07-10 23:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 23:02 Douglas Anderson [this message]
2020-07-10 23:02 ` [PATCH 1/9] drm/msm: Use the devm variant of of_platform_populate() Douglas Anderson
2020-07-10 23:02 ` [PATCH 2/9] dt-bindings: msm/dpu: Add simple-bus to dpu bindings Douglas Anderson
2020-07-10 23:02 ` [PATCH 3/9] dt-bindings: msm/mdp5: " Douglas Anderson
2020-07-10 23:02 ` [PATCH 4/9] drm/msm: Avoid manually populating our children if "simple-bus" is there Douglas Anderson
2020-07-10 23:02 ` [PATCH 5/9] arm64: dts: qcom: sc7180: Add "simple-bus" to our mdss node Douglas Anderson
2020-07-10 23:02 ` [PATCH 6/9] arm64: dts: qcom: sdm845: " Douglas Anderson
2020-07-10 23:02 ` [PATCH 7/9] arm64: dts: qcom: msm8916: " Douglas Anderson
2020-07-10 23:02 ` [PATCH 8/9] arm64: dts: qcom: msm8996: " Douglas Anderson
2020-07-10 23:02 ` [PATCH 9/9] ARM: dts: qcom: msm8974: " Douglas Anderson
2020-07-13 14:11 ` [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting Rob Herring
2020-07-13 14:58 ` [Freedreno] " Jeffrey Hugo
2020-07-13 15:08 ` Doug Anderson
2020-07-13 20:25 ` Rob Herring
2020-07-13 21:32 ` Rob Clark
2020-07-13 23:50 ` Doug Anderson
2020-07-14 16:32 ` [Freedreno] " Jeffrey Hugo
2020-07-14 22:13 ` Rob Herring
2020-07-14 22:52 ` Bjorn Andersson
2020-07-15 17:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710230224.2265647-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).