From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavel Machek <pavel@denx.de>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Dan Murphy" <dmurphy@ti.com>, "Jiri Slaby" <jslaby@suse.com>,
kernel@pengutronix.de, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
"Johan Hovold" <johan@kernel.org>
Subject: Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger
Date: Sun, 12 Jul 2020 11:31:55 +0200 [thread overview]
Message-ID: <20200712093155.GA179963@kroah.com> (raw)
In-Reply-To: <20200712090731.GB13495@amd>
On Sun, Jul 12, 2020 at 11:07:31AM +0200, Pavel Machek wrote:
> On Sun 2020-07-12 11:02:17, Greg Kroah-Hartman wrote:
> > On Sun, Jul 12, 2020 at 10:50:59AM +0200, Pavel Machek wrote:
> > > On Sun 2020-07-12 10:43:52, Greg Kroah-Hartman wrote:
> > > > On Sun, Jul 12, 2020 at 10:24:53AM +0200, Pavel Machek wrote:
> > > > > > +++ b/drivers/leds/trigger/ledtrig-tty.c
> > > > > > @@ -0,0 +1,192 @@
> > > > > > +// SPDX-License-Identifier: GPL-2.0
> > > > >
> > > > > 2.0+ is preffered.
> > > >
> > > > No it is not, that's up to the developer.
> > >
> > > For code I maintain, yes it is.
> >
> > That's up to the developer of the code, not the maintainer, as the
> > maintainer is not the copyright holder of it. For new files, it is up
> > to the author of that code. No maintainer should impose a license rule
> > like this on their subsystem, that's just not ok at all. The only
> > "rule" is that it is compatible with GPLv2, nothing else.
>
> No, see for example device tree rules.
Note, I don't agree with that rule, and if you have noticed, it's not
really enforced.
> Plus, IIRC it was you who asked the developer to "doublecheck with
> their legal" when you seen GPL-2.0+. You can't really prevent me from
> doing the same.
Asking to verify that a specific license is what they really want it to
be and they know the ramifications of it is NOT the same as saying "For
code in the subsystem I maintain it has to be GPLv2+".
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-12 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 16:59 [PATCH v7 0/3] leds: trigger: implement a tty trigger Uwe Kleine-König
2020-07-07 16:59 ` [PATCH v7 1/3] tty: rename tty_kopen() and add new function tty_kopen_shared() Uwe Kleine-König
2020-07-07 16:59 ` [PATCH v7 2/3] tty: new helper function tty_get_icount() Uwe Kleine-König
2020-07-07 16:59 ` [PATCH v7 3/3] leds: trigger: implement a tty trigger Uwe Kleine-König
2020-07-12 8:24 ` Pavel Machek
2020-07-12 8:43 ` Greg Kroah-Hartman
2020-07-12 8:50 ` Pavel Machek
2020-07-12 9:02 ` Greg Kroah-Hartman
2020-07-12 9:07 ` Pavel Machek
2020-07-12 9:31 ` Greg Kroah-Hartman [this message]
2020-07-13 10:26 ` Uwe Kleine-König
2020-07-14 7:13 ` Johan Hovold
2020-07-21 19:48 ` Uwe Kleine-König
2020-07-22 8:34 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712093155.GA179963@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@denx.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).