* [PATCH] drm/vkms: change the max cursor width/height
@ 2020-07-10 16:03 Melissa Wen
2020-07-12 22:05 ` Rodrigo Siqueira
0 siblings, 1 reply; 3+ messages in thread
From: Melissa Wen @ 2020-07-10 16:03 UTC (permalink / raw)
To: Rodrigo Siqueira, Haneen Mohammed, Daniel Vetter, David Airlie,
Rodrigo Siqueira
Cc: dri-devel, linux-kernel, kernel-usp, twoerner
This change expands the coverage for the IGT kms_cursor_crc test, where
the size varies between 64 and 512 for a square cursor. With this, in
addition to the cursor 64x64, this patch enables the test of cursors with
sizes: 128x128, 256x256, and 512x512.
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
---
drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 1e8b2169d834..57a8a397d5e8 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
dev->mode_config.min_height = YRES_MIN;
dev->mode_config.max_width = XRES_MAX;
dev->mode_config.max_height = YRES_MAX;
+ dev->mode_config.cursor_width = 512;
+ dev->mode_config.cursor_height = 512;
dev->mode_config.preferred_depth = 24;
dev->mode_config.helper_private = &vkms_mode_config_helpers;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vkms: change the max cursor width/height
2020-07-10 16:03 [PATCH] drm/vkms: change the max cursor width/height Melissa Wen
@ 2020-07-12 22:05 ` Rodrigo Siqueira
2020-07-12 22:11 ` Rodrigo Siqueira
0 siblings, 1 reply; 3+ messages in thread
From: Rodrigo Siqueira @ 2020-07-12 22:05 UTC (permalink / raw)
To: Melissa Wen
Cc: Haneen Mohammed, Daniel Vetter, David Airlie, Rodrigo Siqueira,
dri-devel, linux-kernel, kernel-usp, twoerner
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
Hi Melissa,
First of all, thanks a lot for your patch! This is a nice change since
it increases the code coverage.
Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
On 07/10, Melissa Wen wrote:
> This change expands the coverage for the IGT kms_cursor_crc test, where
> the size varies between 64 and 512 for a square cursor. With this, in
> addition to the cursor 64x64, this patch enables the test of cursors with
> sizes: 128x128, 256x256, and 512x512.
>
> Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 1e8b2169d834..57a8a397d5e8 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> dev->mode_config.min_height = YRES_MIN;
> dev->mode_config.max_width = XRES_MAX;
> dev->mode_config.max_height = YRES_MAX;
> + dev->mode_config.cursor_width = 512;
> + dev->mode_config.cursor_height = 512;
> dev->mode_config.preferred_depth = 24;
> dev->mode_config.helper_private = &vkms_mode_config_helpers;
>
> --
> 2.27.0
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vkms: change the max cursor width/height
2020-07-12 22:05 ` Rodrigo Siqueira
@ 2020-07-12 22:11 ` Rodrigo Siqueira
0 siblings, 0 replies; 3+ messages in thread
From: Rodrigo Siqueira @ 2020-07-12 22:11 UTC (permalink / raw)
To: Melissa Wen
Cc: Haneen Mohammed, Daniel Vetter, David Airlie, Rodrigo Siqueira,
dri-devel, linux-kernel, kernel-usp, twoerner
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
Applied to drm-misc-next.
Thanks
On 07/12, Rodrigo Siqueira wrote:
> Hi Melissa,
>
> First of all, thanks a lot for your patch! This is a nice change since
> it increases the code coverage.
>
> Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
>
> On 07/10, Melissa Wen wrote:
> > This change expands the coverage for the IGT kms_cursor_crc test, where
> > the size varies between 64 and 512 for a square cursor. With this, in
> > addition to the cursor 64x64, this patch enables the test of cursors with
> > sizes: 128x128, 256x256, and 512x512.
> >
> > Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> > ---
> > drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> > index 1e8b2169d834..57a8a397d5e8 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> > dev->mode_config.min_height = YRES_MIN;
> > dev->mode_config.max_width = XRES_MAX;
> > dev->mode_config.max_height = YRES_MAX;
> > + dev->mode_config.cursor_width = 512;
> > + dev->mode_config.cursor_height = 512;
> > dev->mode_config.preferred_depth = 24;
> > dev->mode_config.helper_private = &vkms_mode_config_helpers;
> >
> > --
> > 2.27.0
> >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-12 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-10 16:03 [PATCH] drm/vkms: change the max cursor width/height Melissa Wen
2020-07-12 22:05 ` Rodrigo Siqueira
2020-07-12 22:11 ` Rodrigo Siqueira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).