From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBF2C433E0 for ; Mon, 13 Jul 2020 11:23:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01D4E2072D for ; Mon, 13 Jul 2020 11:23:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I3YD8cpE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729607AbgGMLXa (ORCPT ); Mon, 13 Jul 2020 07:23:30 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:35470 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728714AbgGMLX2 (ORCPT ); Mon, 13 Jul 2020 07:23:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594639405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cp13jJuIIl8muXNVHzNvpxZz6DmTE1jSSxstK7LrSuw=; b=I3YD8cpEE4+NDUiKJZs0nC847r4KvTlXO5w+cYdNCz+RB7DA8nBMVFq5U5oA0C2vP7ilN4 1k00JdZlNvegDiGid8fBmAQMLoZK41kC7W6zXQUD9re9jvSDfRqRqyWc7uPdFwTuy+YGPS v5nOrzgpFjA04oerRdCrjUnVpQjj1rA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-N0aoTgdMOd-JZm0_ISRZ5w-1; Mon, 13 Jul 2020 07:23:23 -0400 X-MC-Unique: N0aoTgdMOd-JZm0_ISRZ5w-1 Received: by mail-wr1-f70.google.com with SMTP id b8so17416519wro.19 for ; Mon, 13 Jul 2020 04:23:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Cp13jJuIIl8muXNVHzNvpxZz6DmTE1jSSxstK7LrSuw=; b=tZHbhH1kfiIJm1J5rryG8LuuXf8ZVMHLsk6IjBS5JxTNjzUGhjniNEcVCOqjkGDu+r YtruVXOlETRK8YJro4LYd3/p1mDo6zdn08nY9GMVjwjhZq+pCwDSvJ/brRRzq0vVdBPG b5uZBctVinWUoYof/LcunVw/bnzfI2oPurQClSs00HR45k3au5Jas9YbAnG03UsKrj4v L5TCHkNoMu9QkBUTiqE0f5cLiRH2p3EqgGUcxVvB8p2OoktDrqt83SGPMRmJdRVjv7Ub kfuoLr+sqtM8KsPa/mI2LbHpWvbMNAJEAJJpm2nz5Jb2QEq762VqQYt+0DFSoIPDmpTk SW6g== X-Gm-Message-State: AOAM530yUzB8c4x6nKz1xRSccMuXR9qDGQkl5t54HOHLxI7fQx/0PHs9 K4kLvRQ7ErD9h80hQ/YrRMo8L3dU9JLr1MkayY8Z56vvUl0btOKfdEKB4xy4JjM/qM6aDMVbrKA SZeq8kHx06y2VY4nPD+lWPbny X-Received: by 2002:adf:84e2:: with SMTP id 89mr82610821wrg.139.1594639402329; Mon, 13 Jul 2020 04:23:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzoCrHCmvHA+9tYCCZvkKCKZhV/F4YlMxW4KU+tbDXUAXf+8nTnhjTJ8IHP6HmlwcPSxo1PQ== X-Received: by 2002:adf:84e2:: with SMTP id 89mr82610801wrg.139.1594639402164; Mon, 13 Jul 2020 04:23:22 -0700 (PDT) Received: from redhat.com (bzq-79-180-10-140.red.bezeqint.net. [79.180.10.140]) by smtp.gmail.com with ESMTPSA id m16sm25473869wro.0.2020.07.13.04.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 04:23:21 -0700 (PDT) Date: Mon, 13 Jul 2020 07:23:13 -0400 From: "Michael S. Tsirkin" To: Lee Jones Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Jason Wang , Stefan Hajnoczi , virtualization@lists.linux-foundation.org, Paolo Bonzini Subject: Re: [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header Message-ID: <20200713071453-mutt-send-email-mst@kernel.org> References: <20200713080001.128044-1-lee.jones@linaro.org> <20200713080001.128044-13-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713080001.128044-13-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 08:59:49AM +0100, Lee Jones wrote: > This is the only use of kerneldoc in the sourcefile and no > descriptions are provided. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'vscsi' not described in 'virtscsi_complete_cmd' > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'buf' not described in 'virtscsi_complete_cmd' > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Stefan Hajnoczi > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Lee Jones > Acked-by: Paolo Bonzini Acked-by: Michael S. Tsirkin Pls merge with the rest of the patches (which tree is this for?) > --- > drivers/scsi/virtio_scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > index 0e0910c5b9424..56875467e4984 100644 > --- a/drivers/scsi/virtio_scsi.c > +++ b/drivers/scsi/virtio_scsi.c > @@ -100,7 +100,7 @@ static void virtscsi_compute_resid(struct scsi_cmnd *sc, u32 resid) > scsi_set_resid(sc, resid); > } > > -/** > +/* > * virtscsi_complete_cmd - finish a scsi_cmd and invoke scsi_done > * > * Called with vq_lock held. > -- > 2.25.1