From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A1EC433E0 for ; Mon, 13 Jul 2020 07:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84C7720720 for ; Mon, 13 Jul 2020 07:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594625358; bh=wH9pZ0J5bWUdTiFJhWxRAJTTx7NtEQPK9UCjRa/jK7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kAK3zdv5ObPBdviCWANA9f7A6wpH49OPZx2u+9dauwe3HTIAxSJL7q4QBWYzvhl4C nwHxBdA1cvjMa0Yd8SmN8EbwSjMYvIkkzOLELp8Vb5XZR0Z0RVHSuDjsluyz/CPB9+ lUyQm50FNmwUZT2pGRW6S9C5JwXQW2NSG399/QZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729021AbgGMH3Q (ORCPT ); Mon, 13 Jul 2020 03:29:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:52234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbgGMH3Q (ORCPT ); Mon, 13 Jul 2020 03:29:16 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2169520702; Mon, 13 Jul 2020 07:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594625355; bh=wH9pZ0J5bWUdTiFJhWxRAJTTx7NtEQPK9UCjRa/jK7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ryWVQ+XV3las/FRbxq1767YRgb9HORE0IMpdnnTVaJjAhgJEkLaaF58sfg+942NJY UFt8bcCOpl0uBXd0lLHd0M/k/HhzzoOmPS03fpYe4i7uz92iO+FYjLNzM+3cXHEnXM JqjVP4pLQgsLnEwm1QZCXqPB8nDioCyKZy1NKums= Received: by pali.im (Postfix) id 67D4C857; Mon, 13 Jul 2020 09:29:12 +0200 (CEST) Date: Mon, 13 Jul 2020 09:29:12 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andy Shevchenko Cc: Mario Limonciello , Andy Shevchenko , Darren Hart , Linux Kernel Mailing List , Platform Driver , Matthew Garrett , y.linux@paritcher.com Subject: Re: [PATCH v4 0/3] platform/x86: dell-wmi: new keys Message-ID: <20200713072912.ibpojadruifdgnu2@pali> References: <7fb650f568b44eb78e37aa8a534a69d7@AUSX13MPC105.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 09 July 2020 22:29:42 Andy Shevchenko wrote: > On Wed, Jun 10, 2020 at 10:23 PM wrote: > > > > > -----Original Message----- > > > From: Y Paritcher > > > Sent: Wednesday, June 10, 2020 12:57 PM > > > To: Pali Rohár > > > Cc: linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; > > > Matthew Garrett; Limonciello, Mario > > > Subject: [PATCH v4 0/3] platform/x86: dell-wmi: new keys > > > > > > > > > [EXTERNAL EMAIL] > > > > > > change since v3: > > > No code changes. > > > Update commit message to reflect info given by Mario at dell. > > > > > > Is there anything more i have to do for the patches that were reviewed > > > or will they be picked up by the maintainers? > > > Thanks > > > > > > Y Paritcher (3): > > > platform/x86: dell-wmi: add new backlight events > > > platform/x86: dell-wmi: add new keymap type 0x0012 > > > platform/x86: dell-wmi: add new dmi mapping for keycode 0xffff > > > > > > drivers/platform/x86/dell-wmi.c | 28 +++++++++++++++++++++++++--- > > > 1 file changed, 25 insertions(+), 3 deletions(-) > > > > > > -- > > > 2.27.0 > > > > Andy, > > > > The whole series looks good to me now. You can put this on the patches > > when they're swooped up. > > > > Reviewed-by: Mario Limonciello > > > > However I would like to note there was a comment that you had a direct question > > asked by Pali that probably got lost in the thread. This was on patch 3/3 on v3. > > I think it's worth answering as it could dictate a follow up patch to change behavior. > > > > The summary of my argument which led to his is nested somewhere in the thread was that > > to most users this isn't useful since they can't act on it. IE they can't use something > > like setkeycodes and go on their merry way. The user who could act on it by coming > > to upstream and submitting questions and patches is more technical and having them > > use dyndbg to turn on the messages about unknown shouldn't be a big deal. > > > > > I'm not sure, but I thought that > > > throwing warning or info message is the correct solution. Driver cannot > > > handle something, so it inform about it, instead of silently dropping > > > event. Same behavior I'm seeing in other kernel drivers. > > > > > But looks like that you and Mario have opposite opinion, that kernel > > > should not log unknown events and rather should drop them. > > > > > I would like to have behavior of dell-wmi same as in other drivers for > > > consistency, so the best would be to ask WMI/platform maintainers. They > > > could have opinion how to handle these problem globally. > > > > > ... > > > > > Darren & Andy, could you please say something to this, what do you think > > > about silently dropping events/actions which are currently unknown for > > > dell-wmi driver? It is better to log them or not? Currently we are > > > logging them. > > > > Can you please advise which way you would rather have the subsystem go? > > Seems Pali is okay with this version, so everything is settled I suppose. > I will add it to my queue, thanks! Hello Andy! Yes, I'm fine with this patch series, but question how to handle these "unknown" events still remains.