From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B51C433E3 for ; Mon, 13 Jul 2020 09:06:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B62D206F0 for ; Mon, 13 Jul 2020 09:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729143AbgGMJG5 (ORCPT ); Mon, 13 Jul 2020 05:06:57 -0400 Received: from mga05.intel.com ([192.55.52.43]:65288 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgGMJG5 (ORCPT ); Mon, 13 Jul 2020 05:06:57 -0400 IronPort-SDR: rdVohcU+3Q4J8OdjmcMcv+WtIWMDq/z+VRX1/DGDiEyD5OQLL28VgMb8zXYQYWSMHzy/0CfB3Y lOza0Ld0/8LA== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="233437816" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="233437816" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 02:06:56 -0700 IronPort-SDR: KngRHk5ve9Vleg4jLe3Lwqo7pjZZCYApD84txpQLS2Jy5hTjkz8pq0XWZz58RlwQEqB80dCovP +52ySHD/mByQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="316001867" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 13 Jul 2020 02:06:53 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1juuQH-001ZDR-KF; Mon, 13 Jul 2020 12:06:53 +0300 Date: Mon, 13 Jul 2020 12:06:53 +0300 From: Andy Shevchenko To: Wei Shuai Cc: "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." , Dmitry Torokhov , Greg Kroah-Hartman , Jeffrey Hugo , Manivannan Sadhasivam , Borislav Petkov , Mattias Jacobsson <2pi@mok.nu>, Mark Gross , Russell King , Erwan Velu , Thomas Gleixner , open list Subject: Re: [PATCH] Input: break joystick limitation of maximum 80 buttons Message-ID: <20200713090653.GB3703480@smile.fi.intel.com> References: <20200710065112.18286-1-cpuwolf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 12, 2020 at 07:54:54AM +0800, Wei Shuai wrote: > The joystick max buttons 80 limitation comes from > > #define BTN_JOYSTICK 0x120 > #define BTN_DEAD 0x12f > #define BTN_TRIGGER_HAPPY 0x2c0 > #define KEY_MAX 0x2ff > > include/uapi/linux/input-event-codes.h > > according to function hidinput_configure_usage() in file drivers/hid/hid-input.c > > the joystick button mapping is not a continues space > generally speaking, the mapping space is from > > 1. BTN_JOYSTICK~BTN_DEAD > 2. BTN_TRIGGER_HAPPY~KEY_MAX > > Finally, I got the max limitation is 80. > The patch is expanding KEY_MAX from 0x2ff to 4ff > and the change has been verified on 104 button USB HID device on Ubuntu If you send and resend this patch too often, nobody will take you seriously. Also, you have to provide versioning and changelog in each submission. Besides that, above doesn't answer to question "why?". Why are you doing this at all? What the problem? -- With Best Regards, Andy Shevchenko