* Re: [PATCH v7 2/8] cpufreq: mediatek: Enable clock and regulator
[not found] ` <1594348284-14199-3-git-send-email-andrew-sh.cheng@mediatek.com>
@ 2020-07-13 9:39 ` Viresh Kumar
[not found] ` <1594732689.24540.4.camel@mtksdaap41>
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2020-07-13 9:39 UTC (permalink / raw)
To: Andrew-sh.Cheng
Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Rob Herring,
Mark Rutland, Matthias Brugger, Rafael J. Wysocki,
Nishanth Menon, Stephen Boyd, Liam Girdwood, Mark Brown,
linux-pm, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, srv_heupstream
On 10-07-20, 10:31, Andrew-sh.Cheng wrote:
> From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
>
> Need to enable regulator,
> so that the max/min requested value will be recorded
> even it is not applied right away.
>
> Intermediate clock is not always enabled by ccf in different projects,
> so cpufreq should enable it by itself.
>
> Change-Id: I9f4c8b1ea793794f5f9cdc65427daad1393f5df8
You are on V7 right now, these should have been gone long back.
> Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 33 +++++++++++++++++++++++++++++----
> 1 file changed, 29 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index 0c98dd08273d..4b479c110cc9 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -350,6 +350,11 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> ret = PTR_ERR(proc_reg);
> goto out_free_resources;
> }
> + ret = regulator_enable(proc_reg);
> + if (ret) {
> + pr_warn("enable vproc for cpu%d fail\n", cpu);
> + goto out_free_resources;
> + }
This is already done by the OPP core now.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v7 5/8] opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled
[not found] ` <1594348284-14199-6-git-send-email-andrew-sh.cheng@mediatek.com>
@ 2020-07-13 9:42 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2020-07-13 9:42 UTC (permalink / raw)
To: Andrew-sh.Cheng
Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Rob Herring,
Mark Rutland, Matthias Brugger, Rafael J. Wysocki,
Nishanth Menon, Stephen Boyd, Liam Girdwood, Mark Brown,
linux-pm, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, srv_heupstream
On 10-07-20, 10:31, Andrew-sh.Cheng wrote:
> From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
>
> Modify dev_pm_opp_get_freq() to return freqeuncy
> even this opp item is not available.
> So that we can get the information of disable opp items.
>
> Change-Id: I54dacf13050397f5080ccdb8b07d6220e7461e4e
> CR-Id:
> Feature:
> Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> ---
> drivers/opp/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index eed42d6b2e6b..5213e0462382 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -118,7 +118,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_get_voltage);
> */
> unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
> {
> - if (IS_ERR_OR_NULL(opp) || !opp->available) {
> + if (IS_ERR_OR_NULL(opp)) {
> pr_err("%s: Invalid parameters\n", __func__);
> return 0;
> }
Please cleanup this patch for all the extra stuff that isn't required mainline
and send it again to me separately from this series.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v7 2/8] cpufreq: mediatek: Enable clock and regulator
[not found] ` <1594732689.24540.4.camel@mtksdaap41>
@ 2020-07-15 3:38 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2020-07-15 3:38 UTC (permalink / raw)
To: andrew-sh.cheng
Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Rob Herring,
Mark Rutland, Matthias Brugger, Rafael J. Wysocki,
Nishanth Menon, Stephen Boyd, Liam Girdwood, Mark Brown,
linux-pm, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, srv_heupstream
On 14-07-20, 21:18, andrew-sh.cheng wrote:
> On Mon, 2020-07-13 at 15:09 +0530, Viresh Kumar wrote:
> > On 10-07-20, 10:31, Andrew-sh.Cheng wrote:
> > > From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
> > >
> > > Need to enable regulator,
> > > so that the max/min requested value will be recorded
> > > even it is not applied right away.
> > >
> > > Intermediate clock is not always enabled by ccf in different projects,
> > > so cpufreq should enable it by itself.
> > >
> > > Change-Id: I9f4c8b1ea793794f5f9cdc65427daad1393f5df8
> >
> > You are on V7 right now, these should have been gone long back.
>
> Hi Viresh,
> Sorry for forgetting to remove the change-ID message.
>
> >
> > > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> > > ---
> > > drivers/cpufreq/mediatek-cpufreq.c | 33 +++++++++++++++++++++++++++++----
> > > 1 file changed, 29 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> > > index 0c98dd08273d..4b479c110cc9 100644
> > > --- a/drivers/cpufreq/mediatek-cpufreq.c
> > > +++ b/drivers/cpufreq/mediatek-cpufreq.c
> > > @@ -350,6 +350,11 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> > > ret = PTR_ERR(proc_reg);
> > > goto out_free_resources;
> > > }
> > > + ret = regulator_enable(proc_reg);
> > > + if (ret) {
> > > + pr_warn("enable vproc for cpu%d fail\n", cpu);
> > > + goto out_free_resources;
> > > + }
> >
> > This is already done by the OPP core now.
>
> Do you mean I can use dev_pm_opp_set_regulators() and
> dev_pm_opp_set_rate() to do dvfs?
> Due to mediatek-cpufreq may change Vproc and Vsram by special flow, that
> is not suitable.
Sorry about that. I completely missed that you aren't using
dev_pm_opp_set_rate().
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-15 3:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1594348284-14199-1-git-send-email-andrew-sh.cheng@mediatek.com>
[not found] ` <1594348284-14199-3-git-send-email-andrew-sh.cheng@mediatek.com>
2020-07-13 9:39 ` [PATCH v7 2/8] cpufreq: mediatek: Enable clock and regulator Viresh Kumar
[not found] ` <1594732689.24540.4.camel@mtksdaap41>
2020-07-15 3:38 ` Viresh Kumar
[not found] ` <1594348284-14199-6-git-send-email-andrew-sh.cheng@mediatek.com>
2020-07-13 9:42 ` [PATCH v7 5/8] opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).