From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63D5C433E4 for ; Mon, 13 Jul 2020 09:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4E922075B for ; Mon, 13 Jul 2020 09:42:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lcI55Yvo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729218AbgGMJmu (ORCPT ); Mon, 13 Jul 2020 05:42:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbgGMJmt (ORCPT ); Mon, 13 Jul 2020 05:42:49 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71F8BC08C5DB for ; Mon, 13 Jul 2020 02:42:49 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id k71so5985150pje.0 for ; Mon, 13 Jul 2020 02:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kucW4jxemtt/pXZ+E7AnSMC/PbTa/AsJZUR8UTzZMJ4=; b=lcI55YvoWw3tjd74BpYl3dOvn6cD8IGpI18wAuSDdfI4sk/yUrXuYryw5dMDR3ba1H wsDroptgzsdRf6HDnuuC9KtEUmxNLkSugmrrZZWJ+TrxRInGvzQu+V8U1KyCGsgmzQxz utd2+/BqJCDwDxIeA96VNW5V1m1uo/asivNCEOTBFLElvOGHzz5oKsGQpwERc+BFy2EJ tVygl8BjJ+ZYkfzJlScudQJmmd2ndfRU8setyiwGZRWSA7yS4TGV1osn/KyuhFmsufe5 QoYRNH63+CWoFr39Gaeeza7qt7cIfKrbEIIgbUzn1Fny9/V/FPtfPgrwrwYUwxshYy9F RIzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kucW4jxemtt/pXZ+E7AnSMC/PbTa/AsJZUR8UTzZMJ4=; b=KWCHqiZTSmF2lpmcJBwdf1nk4OyFjOLRSLKIFozh6NxangRN+411OOS5a6syt4n2rh 5gE7rTy0WrHg1WS7aOtz4DHzp+Kn5D8PsiRARLU2X4ut68O+Wve9I4TBO4p/uPZkP3ej 0K58H6CbRqTuTI4nCWHn31NgfsmgHvR8X320aqcwwxvwVdOPu5vLHTSR0ZFcOF9+FJSS 4f4VBFBHHYVibuBDsRaPzsCLK+kdf4JZUms0EAKhddQiQ8NijaGVhTRuDjvr8xJGUskt 0NK8wokgRqJ4vZaA7a+ReOHR6KYSARGEl5lJciqGhI/QNHebrEsEqEBURns1fnrCUrie aJpg== X-Gm-Message-State: AOAM533O27IXKmFvlZk5JLVJxx3hwpUxW6wOJ84OjQVKvHYeus2jHoml VBaflMmNOnepHcw6MdoAitq3eA== X-Google-Smtp-Source: ABdhPJwSWiNCy4GMY/Ku2oHof1ytCHYjNesOLFGJYXH8bvQqNhWsN8dMZuvobXI86tTO3CgigTkIpw== X-Received: by 2002:a17:902:e9d2:: with SMTP id 18mr69294722plk.40.1594633368761; Mon, 13 Jul 2020 02:42:48 -0700 (PDT) Received: from localhost ([122.172.34.142]) by smtp.gmail.com with ESMTPSA id h18sm6620431pfr.186.2020.07.13.02.42.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2020 02:42:48 -0700 (PDT) Date: Mon, 13 Jul 2020 15:12:45 +0530 From: Viresh Kumar To: "Andrew-sh.Cheng" Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Mark Rutland , Matthias Brugger , "Rafael J. Wysocki" , Nishanth Menon , Stephen Boyd , Liam Girdwood , Mark Brown , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH v7 5/8] opp: Modify opp API, dev_pm_opp_get_freq(), find freq in opp, even it is disabled Message-ID: <20200713094245.ktx3oj3i225r74qh@vireshk-i7> References: <1594348284-14199-1-git-send-email-andrew-sh.cheng@mediatek.com> <1594348284-14199-6-git-send-email-andrew-sh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594348284-14199-6-git-send-email-andrew-sh.cheng@mediatek.com> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10-07-20, 10:31, Andrew-sh.Cheng wrote: > From: "Andrew-sh.Cheng" > > Modify dev_pm_opp_get_freq() to return freqeuncy > even this opp item is not available. > So that we can get the information of disable opp items. > > Change-Id: I54dacf13050397f5080ccdb8b07d6220e7461e4e > CR-Id: > Feature: > Signed-off-by: Andrew-sh.Cheng > --- > drivers/opp/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index eed42d6b2e6b..5213e0462382 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -118,7 +118,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_get_voltage); > */ > unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > { > - if (IS_ERR_OR_NULL(opp) || !opp->available) { > + if (IS_ERR_OR_NULL(opp)) { > pr_err("%s: Invalid parameters\n", __func__); > return 0; > } Please cleanup this patch for all the extra stuff that isn't required mainline and send it again to me separately from this series. -- viresh