From: Rob Herring <robh@kernel.org>
To: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
linus.walleij@linaro.org, gregkh@linuxfoundation.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stefano.stabellini@xilinx.com,
tomase@xilinx.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: bus: Add firewall bindings
Date: Mon, 13 Jul 2020 11:01:16 -0600 [thread overview]
Message-ID: <20200713170116.GA364356@bogus> (raw)
In-Reply-To: <20200701132523.32533-2-benjamin.gaignard@st.com>
On Wed, Jul 01, 2020 at 03:25:19PM +0200, Benjamin Gaignard wrote:
> Add schemas for firewall consumer and provider.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../bindings/bus/stm32/firewall-consumer.yaml | 36 ++++++++++++++++++++++
> .../bindings/bus/stm32/firewall-provider.yaml | 18 +++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml
> create mode 100644 Documentation/devicetree/bindings/bus/stm32/firewall-provider.yaml
>
> diff --git a/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml b/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml
> new file mode 100644
> index 000000000000..d3d76f99b38d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common Bus Firewall consumer binding
I'm all for common bindings, but I want to see more than 1 user before
accepting this. There's been some other postings for similar h/w
(AFAICT) recently.
> +
> +description: |
> + Firewall properties provide the possible firewall bus controller
> + configurations for a device.
> + Bus firewall controllers are typically used to control if a hardware
> + block can perform read or write operations on bus.
> + The contents of the firewall bus configuration properties are defined by
> + the binding for the individual firewall controller device.
> +
> + The first configuration 'firewall-0' or the one named 'default' is
> + applied before probing the device itself.
This is a Linux implementation detail and debatable whether the core
should do this or drivers.
> +
> +maintainers:
> + - Benjamin Gaignard <benjamin.gaignard@st.com>
> +
> +# always select the core schema
> +select: true
> +
> +properties:
> + firewall-0: true
> +
> + firewall-names: true
> +
> +patternProperties:
> + "firewall-[0-9]":
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
So I guess multiple properties is to encode all the modes into DT like
pinctrl does. Is that really necessary? I don't think so as I wouldn't
expect modes to be defined by the consumer, but by the provider in this
case. To use pinctrl as a example, we could have pad setting per MMC
speed. That has to be in the consumer side as the pinctrl knows nothing
about MMC.
Rob
next prev parent reply other threads:[~2020-07-13 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 13:25 [PATCH v4 0/5] STM32 ETZPC bus controller Benjamin Gaignard
2020-07-01 13:25 ` [PATCH v4 1/5] dt-bindings: bus: Add firewall bindings Benjamin Gaignard
2020-07-13 17:01 ` Rob Herring [this message]
2020-07-20 9:17 ` Benjamin GAIGNARD
2020-07-01 13:25 ` [PATCH v4 2/5] bus: stm32: Introduce firewall controller helpers Benjamin Gaignard
2020-07-01 13:25 ` [PATCH v4 3/5] dt-bindings: bus: Add STM32 ETZPC firewall controller Benjamin Gaignard
2020-07-13 17:05 ` Rob Herring
2020-07-20 9:21 ` Benjamin GAIGNARD
2020-07-01 13:25 ` [PATCH v4 4/5] bus: stm32: Add stm32 ETZPC firewall bus controller Benjamin Gaignard
2020-07-01 13:25 ` [PATCH v4 5/5] ARM: dts: stm32: Use ETZPC firewall bus Benjamin Gaignard
-- strict thread matches above, loose matches on Subject: below --
2020-06-05 8:33 [PATCH v4 0/5] STM32 ETZPC bus controller Benjamin Gaignard
2020-06-05 8:33 ` [PATCH v4 1/5] dt-bindings: bus: Add firewall bindings Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713170116.GA364356@bogus \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=stefano.stabellini@xilinx.com \
--cc=tomase@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).