From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Cc: linux-pwm@vger.kernel.org, thierry.reding@gmail.com,
p.zabel@pengutronix.de, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andriy.shevchenko@intel.com, songjun.Wu@intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
rahul.tanwar.linux@gmail.com
Subject: Re: [PATCH v4 2/2] Add PWM fan controller driver for LGM SoC
Date: Tue, 14 Jul 2020 09:18:10 +0200 [thread overview]
Message-ID: <20200714071810.2gfrot2zupal2cn6@pengutronix.de> (raw)
In-Reply-To: <3e0623c7-45cd-ea60-bae3-a03d991e98bf@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
Hello Rahul,
On Tue, Jul 14, 2020 at 01:35:14PM +0800, Tanwar, Rahul wrote:
> On 14/7/2020 3:10 am, Uwe Kleine-König wrote:
> > On Tue, Jun 30, 2020 at 03:55:32PM +0800, Rahul Tanwar wrote:
> Given the fact that this is a dedicated PWM fan controller with no other
> PWM consumer, do you think that this driver belongs to drivers/hwmon
> instead of drivers/pwm? Thanks.
If you implement the PWM API it belongs to drivers/pwm I'd say. (There
are some "mixed" drivers that implement both GPIO and PWM that live in
drivers/gpio, but if the support can be separated in a sane way, such
mixing isn't welcome.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-14 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 7:55 [PATCH v4 0/2] pwm: intel: Add PWM driver for a new SoC Rahul Tanwar
2020-06-30 7:55 ` [PATCH v4 1/2] Add DT bindings YAML schema for PWM fan controller of LGM SoC Rahul Tanwar
2020-07-13 16:46 ` Rob Herring
2020-07-14 5:32 ` Tanwar, Rahul
2020-06-30 7:55 ` [PATCH v4 2/2] Add PWM fan controller driver for " Rahul Tanwar
2020-07-13 19:10 ` Uwe Kleine-König
2020-07-14 5:35 ` Tanwar, Rahul
2020-07-14 7:18 ` Uwe Kleine-König [this message]
2020-07-23 4:16 ` Tanwar, Rahul
2020-07-23 6:34 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714071810.2gfrot2zupal2cn6@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar.linux@gmail.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=songjun.Wu@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).