From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A2AC433E1 for ; Tue, 14 Jul 2020 07:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B900620C56 for ; Tue, 14 Jul 2020 07:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594712234; bh=40U6VTXe/lr6IqsUj4uyhrm9QvKozidHXSzQ9Zqf+jo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pA7PeJ7pNGIGelxLtQja6RmIjxb814uoW4oPYxm1rdvMl31dXiZH3BFxWXh4j9gTE c1983A7j2K/Ga4nlhfyJxeHR2lmLUrbKnYZgiSK0Q1QdYbG7BDmc4sDr3ll1iF7gsZ uUhxlDCMvJxGi2ydPi3lC0TS2hE32ROEy7UtWwLA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbgGNHhN (ORCPT ); Tue, 14 Jul 2020 03:37:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:37996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgGNHhN (ORCPT ); Tue, 14 Jul 2020 03:37:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C8122084C; Tue, 14 Jul 2020 07:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594712232; bh=40U6VTXe/lr6IqsUj4uyhrm9QvKozidHXSzQ9Zqf+jo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f/FYDnjUC84jxEf2D4SCbed8LMHWZuCqvzYjhvq+wkItyXvbngmhjmVg69RK9laqt 80scyy3fZWGgU0YOmwN5xs+oz4kxKLX2/Oc0Eb5nWJL5U/TgfjZVV2hvjm3Lt+ZK3F zwnpj6uq+s8Y5Afc6GgXETqgCOLV0orSHDh8u8lA= Date: Tue, 14 Jul 2020 09:37:11 +0200 From: Greg KH To: ivan Cc: sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com, Qiwu Huang Subject: Re: [PATCH v2 1/5] power: supply: core: add quick charge type property Message-ID: <20200714073711.GA689066@kroah.com> References: <38b7b1dc10cf608faceae923374791a52a450919.1594612572.git.huangqiwu@xiaomi.com> <20200713084113.GC215949@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Jul 14, 2020 at 03:31:52PM +0800, ivan wrote: > I think we should add an enumederated for this What is "this"? > > for example > > abi document > > What: /sys/class/power_supply//quick_charge_type > Date: Jul 2020 > Contact: Fei Jiang > Description: > Reports the kind of quick charge type based on different adapter power. > Different quick charge type represent different charging power. > QUICK_CHARGE_NORMAL : Charging Power <= 10W > QUICK_CHARGE_FAST : 10W < Charging Power <= 20W > QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W > QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W > QUICK_CHARGE_SUPER : Charging Power > 50W > > Access: Read-Only > Valid values: > 0: QUICK_CHARGE_NORMAL, > 1: QUICK_CHARGE_FAST, > 2: QUICK_CHARGE_FLASH, > 3: QUICK_CHARGE_TURBE, > 4: QUICK_CHARGE_SUPER. > > > power_supply.h > > enum power_supply_quick_charge_type { > QUICK_CHARGE_NORMAL = 0, > QUICK_CHARGE_FAST, > QUICK_CHARGE_FLASH, > QUICK_CHARGE_TURBE, > QUICK_CHARGE_SUPER, > QUICK_CHARGE_MAX, > }; That seems like a good change, why not do this? :) thanks, greg k-h