From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD55C433EB for ; Tue, 14 Jul 2020 13:55:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 802B820760 for ; Tue, 14 Jul 2020 13:55:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AqOLcnvw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728092AbgGNNzC (ORCPT ); Tue, 14 Jul 2020 09:55:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbgGNNzB (ORCPT ); Tue, 14 Jul 2020 09:55:01 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3F8AC061755 for ; Tue, 14 Jul 2020 06:55:00 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id r12so21692497wrj.13 for ; Tue, 14 Jul 2020 06:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NBl6qTXtY70y2AbXcuTUZ62FPRexxmOk23eaRBsntgA=; b=AqOLcnvw3OiqvcM4Zn8Gj7MsWpqfygrPWiSuIpNhmQ3HEnpVRCyuWIRjrhEF6yK54s uJbvDHTZ9DTvRD0GE/W/oJY3yP1KdOO706UKdbmhoJvTYszJ5MtsU8nMjzx/yHt3iYda AQ4hnTtC3xXstiduFRxNmUnHv6ypu+oGd3sDtyeRAbL4xgc61rQKEOSvNrX8axJ6tdZz KPk8VhfNS7FLCrPWVb2dZnmCWbkGJnNkyBucMLPfihDXeKI1VrxCAJnsI4Q/e2snIOzP cQC0xrRkaioXHK9t/DxZW9RtBf3yeuRFIclbU8gPmKSxgx+W3CDMvZIpkP9HQsct6QCl T6wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NBl6qTXtY70y2AbXcuTUZ62FPRexxmOk23eaRBsntgA=; b=tdp1mbTu4gjQHqczBa68SWaEX0umgARF4WwnLw/r2xdl3n28WplZwrOWlilgjnpNvf eC/uLiVZVRRxq4A4xEUYXRWwF1fkcxU59gBSer4pSvA7LILwD9dvW22/a5cLl9w2Ss+A vob0CReNEMnEe9taAgKUghFD9Acj6P3WNCgCdKmNDtybOWX/jq+dZ5KAUHfq59TXgs/X 2SaoH3wU/MIMQuY8iKQUZWx+Utgw+oeyGa5A3I83OIicBLyM6V384rmQmDfLZsoHWA+T 7FVwCdAlJvGGiVg18UJl1bI7oPhXN3pEP4CRVsGEkcS/RcKslrGPIX4FyPr6VF8gcD6c jgLg== X-Gm-Message-State: AOAM532bIpuglnTSyvRyX04Jw9xxqXu11KXxs1Rsb6yYtToLiP42AKEJ rGnh5NNP2mX+JCcsym3skywmPRWAt/Y= X-Google-Smtp-Source: ABdhPJxCS6QuKrXyXdOkP6wM0S8ieLrJvySK5vovEEs/0nduckyaFy8F3h1Y1MLlt0oQsqL0NW/XWA== X-Received: by 2002:adf:e74e:: with SMTP id c14mr5941520wrn.143.1594734898874; Tue, 14 Jul 2020 06:54:58 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id k126sm4968334wme.17.2020.07.14.06.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 06:54:58 -0700 (PDT) Date: Tue, 14 Jul 2020 14:54:56 +0100 From: Lee Jones To: Hans de Goede Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Guenter Roeck , Heikki Krogerus Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Message-ID: <20200714135456.GB1398296@dell> References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-9-lee.jones@linaro.org> <20200706142051.GA3500@dell> <65f27abc-69c8-3877-be5b-e5e478153af9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <65f27abc-69c8-3877-be5b-e5e478153af9@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jul 2020, Hans de Goede wrote: > Hi, > > On 7/6/20 4:20 PM, Lee Jones wrote: > > On Mon, 06 Jul 2020, Hans de Goede wrote: > > > > > Hi, > > > > > > On 7/6/20 3:33 PM, Lee Jones wrote: > > > > Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config > > > > configuration mechanism") pulled out the only use of 'tcpm_altmode_ops' > > > > last year. No need to keep it around. > > > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] > > > > 1551 | static const struct typec_altmode_ops tcpm_altmode_ops = { > > > > | ^~~~~~~~~~~~~~~~ > > > > > > > > Cc: Guenter Roeck > > > > Cc: Heikki Krogerus > > > > Cc: Hans de Goede > > > > Signed-off-by: Lee Jones > > > > > > This is necessary for adding Display port over Type-C support > > > on devices using the tcpm code, rather then firmware, to do > > > the Type-C alt-mode negotiation. > > > > > > I have a local patch in my tree which adds support for this. > > > > > > But Heikki did not like my approach, so that patch > > > (which needs the bits you are removing) never landed > > > upstream: > > > > > > https://patchwork.kernel.org/patch/11199517/ > > > > > > Which is somewhat old now. > > > > Yes, that's a just a little old now. > > > > If it drags on for much longer, perhaps consider taking it out for the > > time being and adding it back when you start to make use of it again? > > Ok, I've just submitted a reworked patch-series upstream which > actually uses this code. So please drop this patch from your > patch-set. No problem. Thanks Hans. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog