linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: rjw@rjwysocki.net, viresh.kumar@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static
Date: Tue, 14 Jul 2020 15:50:42 +0100	[thread overview]
Message-ID: <20200714145049.2496163-7-lee.jones@linaro.org> (raw)
In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype for ‘gpstate_timer_handler’ [-Wmissing-prototypes]
 drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes]

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/cpufreq/powernv-cpufreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
index 8646eb197cd96..068cc53abe320 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -666,7 +666,7 @@ static inline void  queue_gpstate_timer(struct global_pstate_info *gpstates)
  * according quadratic equation. Queues a new timer if it is still not equal
  * to local pstate
  */
-void gpstate_timer_handler(struct timer_list *t)
+static void gpstate_timer_handler(struct timer_list *t)
 {
 	struct global_pstate_info *gpstates = from_timer(gpstates, t, timer);
 	struct cpufreq_policy *policy = gpstates->policy;
@@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = {
 	.notifier_call = powernv_cpufreq_reboot_notifier,
 };
 
-void powernv_cpufreq_work_fn(struct work_struct *work)
+static void powernv_cpufreq_work_fn(struct work_struct *work)
 {
 	struct chip *chip = container_of(work, struct chip, throttle);
 	struct cpufreq_policy *policy;
-- 
2.25.1


  parent reply	other threads:[~2020-07-14 14:51 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 14:50 [PATCH 00/13] Rid W=1 warnings in CPUFreq Lee Jones
2020-07-14 14:50 ` [PATCH 01/13] cpufreq: freq_table: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-15  2:44   ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Lee Jones
2020-07-15  2:49   ` Viresh Kumar
2020-07-15  6:47     ` Lee Jones
2020-07-15  7:09       ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 03/13] cpufreq: cpufreq_governor: Demote store_sampling_rate() header to standard comment block Lee Jones
2020-07-15  2:52   ` Viresh Kumar
2020-07-15  6:45     ` Lee Jones
2020-07-15  7:08       ` Viresh Kumar
2020-07-15  7:31         ` Lee Jones
2020-07-15  8:02           ` Viresh Kumar
2020-07-15  8:15             ` Lee Jones
2020-07-14 14:50 ` [PATCH 04/13] cpufreq: sti-cpufreq: Fix some formatting and misspelling issues Lee Jones
2020-07-15  2:58   ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Lee Jones
2020-07-15  3:07   ` Viresh Kumar
2020-07-15  3:49     ` Olof Johansson
2020-07-15  3:51       ` Viresh Kumar
2020-07-15  6:36       ` Lee Jones
2020-07-15  6:39         ` Viresh Kumar
2020-07-15  3:26   ` Olof Johansson
2020-07-15  6:33     ` Lee Jones
2020-07-15  6:46       ` Olof Johansson
2020-07-15  7:33         ` Lee Jones
2020-07-14 14:50 ` Lee Jones [this message]
2020-07-15  3:07   ` [PATCH 06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static Viresh Kumar
2020-07-14 14:50 ` [PATCH 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Lee Jones
2020-07-15  3:09   ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 08/13] cpufreq: acpi-cpufreq: Take 'dummy' principle one stage further Lee Jones
2020-07-14 16:03   ` Rafael J. Wysocki
2020-07-14 16:20     ` Robin Murphy
2020-07-14 21:00       ` Lee Jones
2020-07-14 14:50 ` [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs Lee Jones
2020-07-14 15:58   ` Rafael J. Wysocki
2020-07-14 21:03     ` Lee Jones
2020-07-15  3:24       ` Viresh Kumar
2020-07-15  3:27         ` Viresh Kumar
2020-07-15  6:37           ` Lee Jones
2020-07-15 11:27           ` Rafael J. Wysocki
2020-07-15 11:34             ` Lee Jones
2020-07-15 11:44               ` Rafael J. Wysocki
2020-07-15 11:50                 ` Lee Jones
2020-07-15 12:07                   ` Lee Jones
2020-07-15 12:11                     ` Rafael J. Wysocki
2020-07-15 12:09                   ` Rafael J. Wysocki
2020-07-15 12:16                     ` Lee Jones
2020-07-15 12:30                       ` Robin Murphy
2020-07-15 12:38                         ` Lee Jones
2020-07-14 14:50 ` [PATCH 10/13] cpufreq: powernow-k8: Make use of known set but not used variables Lee Jones
2020-07-14 17:43   ` Rafael J. Wysocki
2020-07-14 21:01     ` Lee Jones
2020-07-14 14:50 ` [PATCH 11/13] cpufreq: pcc-cpufreq: Remove unused ID structs Lee Jones
2020-07-14 17:42   ` Rafael J. Wysocki
2020-07-14 14:50 ` [PATCH 12/13] cpufreq: intel_pstate: Supply struct attribute description for get_aperf_mperf_shift() Lee Jones
2020-07-14 16:35   ` Rafael J. Wysocki
2020-07-14 21:03     ` Lee Jones
2020-07-15 12:38       ` Rafael J. Wysocki
2020-07-14 14:50 ` [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Lee Jones
2020-07-14 17:15   ` Kim Phillips
2020-07-14 21:02     ` Lee Jones
2020-07-14 21:13       ` Kim Phillips
2020-07-15  6:47         ` Lee Jones
2020-07-15  3:36 ` [PATCH 00/13] Rid W=1 warnings in CPUFreq Viresh Kumar
2020-07-15  6:32   ` Lee Jones
2020-07-15  6:38     ` Viresh Kumar
2020-07-15  7:34       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714145049.2496163-7-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).