From: Lee Jones <lee.jones@linaro.org>
To: Doug Ledford <dledford@redhat.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v2 18/29] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'tinfo'
Date: Tue, 14 Jul 2020 22:08:41 +0100 [thread overview]
Message-ID: <20200714210841.GK1398296@dell> (raw)
In-Reply-To: <95350d0a60d1e305e2053388ada2cbd3310684e3.camel@redhat.com>
On Tue, 14 Jul 2020, Doug Ledford wrote:
> On Mon, 2020-07-13 at 08:46 +0100, Lee Jones wrote:
> > Looks like none of the artifact from ahc_fetch_transinfo() are used
> > anymore.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/scsi/aic7xxx/aic7xxx_osm.c: In function
> > ‘ahc_linux_target_alloc’:
> > drivers/scsi/aic7xxx/aic7xxx_osm.c:567:30: warning: variable ‘tinfo’
> > set but not used [-Wunused-but-set-variable]
> > 567 | struct ahc_initiator_tinfo *tinfo;
> > | ^~~~~
> >
> > Cc: Hannes Reinecke <hare@suse.com>
> > Cc: "Daniel M. Eischen" <deischen@iworks.InterWorks.org>
> > Cc: Doug Ledford <dledford@redhat.com>
>
> FWIW, I can't seem to figure out how you got mine or Dan's email
> addresses as related to this driver. The MAINTAINERS file only lists
> Hannes. The driver Dan and I worked on was a different driver. It was
> named aic7xxx, but that was back in the 1990s. It was renamed to
> aic7xxx_old so that Adaptec could contribute this driver you are
> currently patching back around 2001 or so. And then maybe around 2010
> or something like that, the aic7xxx_old driver that Dan and I worked on
> was removed from the upstream source tree entirely. So, just out of
> curiosity, how did you get mine and Dan's email addresses to put on the
> Cc: list for these patches?
$ ./scripts/get_maintainer.pl --file-emails --git-min-percent 75 -f drivers/scsi/aic7xxx/aic7xxx_osm.c
Hannes Reinecke <hare@suse.com> (maintainer:AIC7XXX / AIC79XX SCSI DRIVER,in file)
"James E.J. Bottomley" <jejb@linux.ibm.com> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM)
"Daniel M. Eischen" <deischen@iworks.InterWorks.org> (in file)
Doug Ledford <dledford@redhat.com> (in file)
linux-scsi@vger.kernel.org (open list:AIC7XXX / AIC79XX SCSI DRIVER)
linux-kernel@vger.kernel.org (open list)
Looks like get_maintainer.pl pulled it from the file header.
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/scsi/aic7xxx/aic7xxx_osm.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> > b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> > index 2edfa0594f183..32bfe20d79cc1 100644
> > --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> > +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> > @@ -564,8 +564,6 @@ ahc_linux_target_alloc(struct scsi_target
> > *starget)
> > struct scsi_target **ahc_targp =
> > ahc_linux_target_in_softc(starget);
> > unsigned short scsirate;
> > struct ahc_devinfo devinfo;
> > - struct ahc_initiator_tinfo *tinfo;
> > - struct ahc_tmode_tstate *tstate;
> > char channel = starget->channel + 'A';
> > unsigned int our_id = ahc->our_id;
> > unsigned int target_offset;
> > @@ -612,9 +610,6 @@ ahc_linux_target_alloc(struct scsi_target
> > *starget)
> > spi_max_offset(starget) = 0;
> > spi_min_period(starget) =
> > ahc_find_period(ahc, scsirate, maxsync);
> > -
> > - tinfo = ahc_fetch_transinfo(ahc, channel, ahc->our_id,
> > - starget->id, &tstate);
> > }
> > ahc_compile_devinfo(&devinfo, our_id, starget->id,
> > CAM_LUN_WILDCARD, channel,
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-14 21:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 7:46 [PATCH v2 00/29] Fix a bunch more SCSI related W=1 warnings Lee Jones
2020-07-13 7:46 ` [PATCH v2 01/29] scsi: libfc: fc_exch: Supply some missing kerneldoc struct/function attributes/params Lee Jones
2020-07-14 6:47 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 02/29] include: scsi: scsi_transport_fc: Match HBA Attribute Length with HBAAPI V2.0 definitions Lee Jones
2020-07-14 6:49 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 03/29] scsi: libfc: fc_disc: trivial: Fix spelling mistake of 'discovery' Lee Jones
2020-07-14 6:50 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 04/29] scsi: fcoe: fcoe: Fix various kernel-doc infringements Lee Jones
2020-07-14 6:58 ` Hannes Reinecke
2020-07-14 7:58 ` Lee Jones
2020-07-14 8:14 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues Lee Jones
2020-07-14 7:00 ` Hannes Reinecke
2020-07-14 7:53 ` Lee Jones
2020-07-14 14:08 ` Martin K. Petersen
2020-07-14 14:23 ` Lee Jones
2020-07-14 16:50 ` Martin K. Petersen
2020-07-14 15:07 ` [PATCH v2.1 " Lee Jones
2020-07-14 15:15 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 06/29] scsi: fcoe: fcoe_transport: Correct some kernel-doc issues Lee Jones
2020-07-14 7:01 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 07/29] scsi: bnx2fc: bnx2fc_fcoe: Repair a range of kerneldoc issues Lee Jones
2020-07-13 7:46 ` [PATCH v2 08/29] scsi: qedf: qedf_main: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-13 7:46 ` [PATCH v2 09/29] scsi: qedf: qedf_main: Remove set but not checked variable 'tmp' Lee Jones
2020-07-13 7:46 ` [PATCH v2 10/29] scsi: libfc: fc_lport: Repair function parameter documentation Lee Jones
2020-07-14 7:04 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 11/29] scsi: libfc: fc_rport: Fix a couple of misdocumented function parameters Lee Jones
2020-07-14 7:04 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 12/29] scsi: libfc: fc_fcp: Provide missing and repair existing function documentation Lee Jones
2020-07-14 7:05 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 13/29] scsi: bnx2fc: bnx2fc_hwi: Fix a couple of bitrotted function documentation headers Lee Jones
2020-07-13 7:46 ` [PATCH v2 14/29] scsi: arcmsr: arcmsr_hba: Remove some set but unused variables Lee Jones
2020-07-13 7:46 ` [PATCH v2 15/29] scsi: arcmsr: arcmsr_hba: Make room for the trailing NULL, even if it is over-written Lee Jones
2020-07-13 7:46 ` [PATCH v2 16/29] scsi: qedf: qedf_io: Remove a whole host of unused variables Lee Jones
2020-07-13 7:46 ` [PATCH v2 17/29] scsi: bnx2fc: bnx2fc_tgt: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-13 7:46 ` [PATCH v2 18/29] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'tinfo' Lee Jones
2020-07-14 16:24 ` Doug Ledford
2020-07-14 21:08 ` Lee Jones [this message]
2020-07-13 7:46 ` [PATCH v2 19/29] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'ahc' Lee Jones
2020-07-14 7:07 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 20/29] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'targ' Lee Jones
2020-07-14 7:07 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 21/29] scsi: aic7xxx: aic7xxx_osm: Fix 'amount_xferred' set but not used issue Lee Jones
2020-07-14 7:08 ` Hannes Reinecke
2020-07-13 7:46 ` [PATCH v2 22/29] scsi: qedf: qedf_debugfs: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-13 7:46 ` [PATCH v2 23/29] scsi: aacraid: linit: Provide suggested curly braces around empty body of if() Lee Jones
2020-07-13 7:46 ` [PATCH v2 24/29] scsi: aacraid: linit: Fix a couple of small kerneldoc issues Lee Jones
2020-07-13 7:46 ` [PATCH v2 25/29] scsi: aic94xx: aic94xx_init: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-13 7:46 ` [PATCH v2 26/29] scsi: pm8001: pm8001_init: Demote obvious misuse of kerneldoc and update others Lee Jones
2020-07-13 7:46 ` [PATCH v2 27/29] scsi: aic94xx: aic94xx_hwi: Repair kerneldoc formatting error and remove extra param Lee Jones
2020-07-13 7:46 ` [PATCH v2 28/29] scsi: aacraid: aachba: Fix a bunch of function doc formatting errors Lee Jones
2020-07-13 7:46 ` [PATCH v2 29/29] scsi: qla4xxx: ql4_init: Provide a missing function param description and fix formatting Lee Jones
2020-07-15 22:14 ` [PATCH v2 00/29] Fix a bunch more SCSI related W=1 warnings Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714210841.GK1398296@dell \
--to=lee.jones@linaro.org \
--cc=dledford@redhat.com \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).