From: Mark Brown <broonie@kernel.org>
To: Qing Zhang <zhangqing@loongson.cn>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] spi: coldfire-qspi: Use clk_prepare_enable and clk_disable_unprepare
Date: Wed, 15 Jul 2020 10:49:40 +0100 [thread overview]
Message-ID: <20200715094940.GB5431@sirena.org.uk> (raw)
In-Reply-To: <1594790807-32319-2-git-send-email-zhangqing@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
On Wed, Jul 15, 2020 at 01:26:47PM +0800, Qing Zhang wrote:
> Convert clk_enable() to clk_prepare_enable() and clk_disable() to
> clk_disable_unprepare() respectively in the spi-coldfire-qspi.c.
Like I said on the previous version are you sure that ColdFire uses the
common clock framework and has the prepare calls?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-15 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 5:26 [PATCH v2 1/2] spi: omap-uwire: Use clk_prepare_enable and clk_disable_unprepare Qing Zhang
2020-07-15 5:26 ` [PATCH v2 2/2] spi: coldfire-qspi: " Qing Zhang
2020-07-15 9:49 ` Mark Brown [this message]
2020-07-16 10:01 ` zhangqing
2020-07-15 14:59 ` [PATCH v2 1/2] spi: omap-uwire: " Mark Brown
2020-07-16 23:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715094940.GB5431@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).