* [PATCH 2/3] ARM: dts: allwinner: convert gpio.h to sunxi-gpio.h
@ 2020-07-15 11:55 Frank Lee
2020-07-17 16:08 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Frank Lee @ 2020-07-15 11:55 UTC (permalink / raw)
To: robh+dt, mripard, wens, tiny.windzz
Cc: devicetree, linux-arm-kernel, linux-kernel, Yangtao Li
From: Yangtao Li <frank@allwinnertech.com>
Use names instead of numbers to describe GPIO. We clean arm64 first.
Since H5 uses the DTS file in arm directory, we need to modify the
header file in advance.
Signed-off-by: Yangtao Li <frank@allwinnertech.com>
---
arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi | 2 +-
arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi b/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
index fc67e30fe212..93f9653b43f4 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
@@ -7,7 +7,7 @@
#include "sunxi-common-regulators.dtsi"
-#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/gpio/sunxi-gpio.h>
/ {
aliases {
diff --git a/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi b/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi
index 19b3b23cfaa8..f6f14b5175e3 100644
--- a/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi
+++ b/arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi
@@ -3,7 +3,7 @@
* Copyright (C) 2017 Chen-Yu Tsai <wens@csie.org>
*/
-#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/gpio/sunxi-gpio.h>
#include <dt-bindings/input/input.h>
/ {
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] ARM: dts: allwinner: convert gpio.h to sunxi-gpio.h
2020-07-15 11:55 [PATCH 2/3] ARM: dts: allwinner: convert gpio.h to sunxi-gpio.h Frank Lee
@ 2020-07-17 16:08 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-07-17 16:08 UTC (permalink / raw)
To: Frank Lee
Cc: robh+dt, wens, tiny.windzz, devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
On Wed, Jul 15, 2020 at 07:55:07PM +0800, Frank Lee wrote:
> From: Yangtao Li <frank@allwinnertech.com>
>
> Use names instead of numbers to describe GPIO. We clean arm64 first.
> Since H5 uses the DTS file in arm directory, we need to modify the
> header file in advance.
>
> Signed-off-by: Yangtao Li <frank@allwinnertech.com>
>
> ---
> arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi | 2 +-
> arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi b/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
> index fc67e30fe212..93f9653b43f4 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
> @@ -7,7 +7,7 @@
>
> #include "sunxi-common-regulators.dtsi"
>
> -#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/gpio/sunxi-gpio.h>
I think we should have both. The gpio.h header is supposed to be for the
generic defines, while ours would be for the one specific to the
allwinner SoCs (just like it's being done for the GIC vs generic
interrupt flags)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-17 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 11:55 [PATCH 2/3] ARM: dts: allwinner: convert gpio.h to sunxi-gpio.h Frank Lee
2020-07-17 16:08 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).