From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 841FDC433DF for ; Wed, 15 Jul 2020 19:23:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CC5D2065D for ; Wed, 15 Jul 2020 19:23:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kiYOUCLw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbgGOTXs (ORCPT ); Wed, 15 Jul 2020 15:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbgGOTXo (ORCPT ); Wed, 15 Jul 2020 15:23:44 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF318C061755 for ; Wed, 15 Jul 2020 12:23:43 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id l6so2781715plt.7 for ; Wed, 15 Jul 2020 12:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OJ/YWMib2y0Oi9xcE3B9cmLij4uK6K7vyJCnBwYrt/0=; b=kiYOUCLw+1YMW5C/hDrCQnyOlnRtGrFPezJA04+b0b4IIM5w8VNidZnsPMPHfZ31KS LxhyDUqGX0RwzJAlBRqOfe2ODGCTv2LKEk/50WpTfn28Dp+ZBxdVxNZXkt6vym0qxK/Q rx82Fv0Ijv3kJKlDTbYSXiKFjVaIlmJguN6+3aaiaOjcY7ZTRMaa5SON4MfuTw8M/HSU v8ruKKdEd2o//mAyXMOkE3cXxzduzOyubtoH4T/VezrAKzRSY9zqMZ+YPOlllJ7ocF+k UdiLFpdNVsXZC/MUNV+4eR0KRB3FESXVCeMno3tw/kkcCifALuCf49tFeBBbwBN9AyNI Cing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OJ/YWMib2y0Oi9xcE3B9cmLij4uK6K7vyJCnBwYrt/0=; b=fkEYkgK2ms3V2qRHz3zUQHcAqOtoJ7fxoMQzb+B7n4VBTmiVrSyU1QWpghv4zftGbO s6nDtUN6PYlRJ1gaHlQ1Ba/QMiJ2GZty3o+OugR/vY12Ir5a2wHdn3Hz/2wppFV7j9vD rnj1RBikArIEsp4xF+fBcyTNAY+mmsiDiA9yuLjvzPY/UCzVzqitwloZW3PKW6zvVWPG w87kjOGhB3MVuR8u+vYb3hkYg6U0VE3b7TGw0OKWM1pjwfyi17Giwr/Cj0SiS/UMBef+ kaJwjkGTycpJFdzVFCsj5nwyv1p/ARoZKDPjXQad+TtHEasv1baagSnBZ+lAbXD84nBJ Lh7A== X-Gm-Message-State: AOAM530YV0V1HSj1jdMinRvnjE/7F8DyQmp6hxqaGbotDYiZNbYPeB65 hsjnGN7jFEcn6ZKAqSFgVcoESE1o+wI= X-Google-Smtp-Source: ABdhPJxxiugzYbbF1aUsgwFCaTWYsI5jJtHeJsIIOQXJcVFYwSl1wCBetM40QxEzTt5KKymF9BCfSw== X-Received: by 2002:a17:90a:ed87:: with SMTP id k7mr1208692pjy.31.1594841023280; Wed, 15 Jul 2020 12:23:43 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g6sm2829878pfr.129.2020.07.15.12.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 12:23:42 -0700 (PDT) Date: Wed, 15 Jul 2020 12:21:38 -0700 From: Bjorn Andersson To: Lee Jones Cc: ohad@wizery.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues Message-ID: <20200715192138.GA2922385@builder.lan> References: <20200715123551.4011154-1-lee.jones@linaro.org> <20200715123551.4011154-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200715123551.4011154-2-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 15 Jul 05:35 PDT 2020, Lee Jones wrote: > Looks as though 'name' has now been moved into 'struct sysmod_event' > which is passed in instead. However, the parameter descriptions were > not updated at the same time. Let's do that now. > > Fixes the following W=1 kernel build warning(s): > > drivers/remoteproc/qcom_sysmon.c:78: warning: Function parameter or member 'event' not described in 'sysmon_send_event' > drivers/remoteproc/qcom_sysmon.c:78: warning: Excess function parameter 'name' description in 'sysmon_send_event' > drivers/remoteproc/qcom_sysmon.c:350: warning: Function parameter or member 'event' not described in 'ssctl_send_event' > drivers/remoteproc/qcom_sysmon.c:350: warning: Excess function parameter 'name' description in 'ssctl_send_event' > > Cc: Andy Gross > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones Thanks Lee, both patches applied. Regards, Bjorn > --- > drivers/remoteproc/qcom_sysmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c > index 8d8996d714f07..9eb2f6bccea63 100644 > --- a/drivers/remoteproc/qcom_sysmon.c > +++ b/drivers/remoteproc/qcom_sysmon.c > @@ -71,7 +71,7 @@ static LIST_HEAD(sysmon_list); > /** > * sysmon_send_event() - send notification of other remote's SSR event > * @sysmon: sysmon context > - * @name: other remote's name > + * @event: sysmon event context > */ > static void sysmon_send_event(struct qcom_sysmon *sysmon, > const struct sysmon_event *event) > @@ -343,7 +343,7 @@ static void ssctl_request_shutdown(struct qcom_sysmon *sysmon) > /** > * ssctl_send_event() - send notification of other remote's SSR event > * @sysmon: sysmon context > - * @name: other remote's name > + * @event: sysmon event context > */ > static void ssctl_send_event(struct qcom_sysmon *sysmon, > const struct sysmon_event *event) > -- > 2.25.1 >