From: Rob Herring <robh@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Daniel M. Weeks" <dan@danweeks.net>,
jdelvare@suse.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Correct vendor for mcp980x
Date: Wed, 15 Jul 2020 15:41:44 -0600 [thread overview]
Message-ID: <20200715214144.GB818608@bogus> (raw)
In-Reply-To: <4884254c-4406-5c04-3df7-030541b7c201@roeck-us.net>
On Fri, Jul 03, 2020 at 02:59:12PM -0700, Guenter Roeck wrote:
> On 7/3/20 8:37 AM, Daniel M. Weeks wrote:
> > Signed-off-by: Daniel M. Weeks <dan@danweeks.net>
> > ---
> > Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
> > drivers/hwmon/lm75.c | 8 ++++----
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> > index 273616702c51..e5bb554cd2c3 100644
> > --- a/Documentation/devicetree/bindings/hwmon/lm75.txt
> > +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> > @@ -14,10 +14,10 @@ Required properties:
> > "maxim,max6626",
> > "maxim,max31725",
> > "maxim,max31726",
> > - "maxim,mcp980x",
> > "nxp,pct2075",
> > "st,stds75",
> > "st,stlm75",
> > + "microchip,mcp980x",
> > "microchip,tcn75",
> > "ti,tmp100",
> > "ti,tmp101",
> > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> > index ba0be48aeadd..a8cfc7e4a685 100644
> > --- a/drivers/hwmon/lm75.c
> > +++ b/drivers/hwmon/lm75.c
> > @@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
> > .compatible = "maxim,max31726",
> > .data = (void *)max31725
> > },
> > - {
> > - .compatible = "maxim,mcp980x",
> > - .data = (void *)mcp980x
> > - },
> > {
> > .compatible = "nxp,pct2075",
> > .data = (void *)pct2075
> > @@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
> > .compatible = "st,stlm75",
> > .data = (void *)stlm75
> > },
> > + {
> > + .compatible = "microchip,mcp980x",
> > + .data = (void *)mcp980x
>
> Hmm, makes me wonder if we should replace this with correct chip names
> since we are at it. After all, it only includes mcp980{0,1,2,3} and not mcp9805.
>
> Rob, any thoughts ?
Do we need to distinguish the chips? Aren't there existing users?
Rob
next prev parent reply other threads:[~2020-07-15 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 15:37 [PATCH] dt-bindings: hwmon: Correct vendor for mcp980x Daniel M. Weeks
2020-07-03 21:59 ` Guenter Roeck
2020-07-15 21:41 ` Rob Herring [this message]
2020-07-15 22:25 ` Guenter Roeck
2020-07-15 21:39 ` Rob Herring
2020-07-15 22:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715214144.GB818608@bogus \
--to=robh@kernel.org \
--cc=dan@danweeks.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).