* [PATCH] can: m_can: Set device to software init mode before closing
@ 2020-07-16 4:23 Faiz Abbas
2020-07-28 6:20 ` Faiz Abbas
0 siblings, 1 reply; 2+ messages in thread
From: Faiz Abbas @ 2020-07-16 4:23 UTC (permalink / raw)
To: linux-kernel, netdev, linux-can
Cc: kuba, davem, mkl, wg, sriram.dash, dmurphy, faiz_abbas
There might be some requests pending in the buffer when the
interface close sequence occurs. In some devices, these
pending requests might lead to the module not shutting down
properly when m_can_clk_stop() is called.
Therefore, move the device to init state before potentially
powering it down.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
drivers/net/can/m_can/m_can.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 02c5795b7393..d0c458f7f6e1 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1414,6 +1414,9 @@ static void m_can_stop(struct net_device *dev)
/* disable all interrupts */
m_can_disable_all_interrupts(cdev);
+ /* Set init mode to disengage from the network */
+ m_can_config_endisable(cdev, true);
+
/* set the state as STOPPED */
cdev->can.state = CAN_STATE_STOPPED;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: m_can: Set device to software init mode before closing
2020-07-16 4:23 [PATCH] can: m_can: Set device to software init mode before closing Faiz Abbas
@ 2020-07-28 6:20 ` Faiz Abbas
0 siblings, 0 replies; 2+ messages in thread
From: Faiz Abbas @ 2020-07-28 6:20 UTC (permalink / raw)
To: linux-kernel, netdev, linux-can
Cc: kuba, davem, mkl, wg, sriram.dash, dmurphy
Hi,
On 16/07/20 9:53 am, Faiz Abbas wrote:
> There might be some requests pending in the buffer when the
> interface close sequence occurs. In some devices, these
> pending requests might lead to the module not shutting down
> properly when m_can_clk_stop() is called.
>
> Therefore, move the device to init state before potentially
> powering it down.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> drivers/net/can/m_can/m_can.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index 02c5795b7393..d0c458f7f6e1 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1414,6 +1414,9 @@ static void m_can_stop(struct net_device *dev)
> /* disable all interrupts */
> m_can_disable_all_interrupts(cdev);
>
> + /* Set init mode to disengage from the network */
> + m_can_config_endisable(cdev, true);
> +
> /* set the state as STOPPED */
> cdev->can.state = CAN_STATE_STOPPED;
> }
>
Gentle ping.
Thanks,
Faiz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-28 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 4:23 [PATCH] can: m_can: Set device to software init mode before closing Faiz Abbas
2020-07-28 6:20 ` Faiz Abbas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).