* [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE
@ 2020-07-16 8:58 Qinglang Miao
2020-07-26 22:09 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Qinglang Miao @ 2020-07-16 8:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sebastian Reichel; +Cc: linux-pm, linux-kernel
From: Yongqiang Liu <liuyongqiang13@huawei.com>
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
---
drivers/power/supply/da9030_battery.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/power/supply/da9030_battery.c b/drivers/power/supply/da9030_battery.c
index 292ecf875..0deba48d2 100644
--- a/drivers/power/supply/da9030_battery.c
+++ b/drivers/power/supply/da9030_battery.c
@@ -172,17 +172,7 @@ static int bat_debug_show(struct seq_file *s, void *data)
return 0;
}
-static int debug_open(struct inode *inode, struct file *file)
-{
- return single_open(file, bat_debug_show, inode->i_private);
-}
-
-static const struct file_operations bat_debug_fops = {
- .open = debug_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(bat_debug);
static struct dentry *da9030_bat_create_debugfs(struct da9030_charger *charger)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE
2020-07-16 8:58 [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
@ 2020-07-26 22:09 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-07-26 22:09 UTC (permalink / raw)
To: Qinglang Miao; +Cc: Greg Kroah-Hartman, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
Hi,
On Thu, Jul 16, 2020 at 04:58:49PM +0800, Qinglang Miao wrote:
> From: Yongqiang Liu <liuyongqiang13@huawei.com>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
Thanks, queued.
-- Sebastian
> drivers/power/supply/da9030_battery.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/power/supply/da9030_battery.c b/drivers/power/supply/da9030_battery.c
> index 292ecf875..0deba48d2 100644
> --- a/drivers/power/supply/da9030_battery.c
> +++ b/drivers/power/supply/da9030_battery.c
> @@ -172,17 +172,7 @@ static int bat_debug_show(struct seq_file *s, void *data)
> return 0;
> }
>
> -static int debug_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, bat_debug_show, inode->i_private);
> -}
> -
> -static const struct file_operations bat_debug_fops = {
> - .open = debug_open,
> - .read_iter = seq_read_iter,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(bat_debug);
>
> static struct dentry *da9030_bat_create_debugfs(struct da9030_charger *charger)
> {
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-26 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 8:58 [PATCH -next] power: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
2020-07-26 22:09 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).