* [PATCH -next] crypto: allwinner - Convert to DEFINE_SHOW_ATTRIBUTE
@ 2020-07-16 9:06 Qinglang Miao
2020-07-20 12:10 ` Corentin Labbe
0 siblings, 1 reply; 2+ messages in thread
From: Qinglang Miao @ 2020-07-16 9:06 UTC (permalink / raw)
To: Greg Kroah-Hartman, Corentin Labbe, Maxime Ripard, Chen-Yu Tsai
Cc: linux-crypto, linux-kernel
From: Chen Huang <chenhuang5@huawei.com>
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Chen Huang <chenhuang5@huawei.com>
---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 15 ++-------------
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 15 ++-------------
2 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
index 52c7785c0..3fe7fe698 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
@@ -279,7 +279,7 @@ static struct sun8i_ce_alg_template ce_algs[] = {
};
#ifdef CONFIG_CRYPTO_DEV_SUN8I_CE_DEBUG
-static int sun8i_ce_dbgfs_read(struct seq_file *seq, void *v)
+static int sun8i_ce_debugfs_show(struct seq_file *seq, void *v)
{
struct sun8i_ce_dev *ce = seq->private;
int i;
@@ -302,18 +302,7 @@ static int sun8i_ce_dbgfs_read(struct seq_file *seq, void *v)
return 0;
}
-static int sun8i_ce_dbgfs_open(struct inode *inode, struct file *file)
-{
- return single_open(file, sun8i_ce_dbgfs_read, inode->i_private);
-}
-
-static const struct file_operations sun8i_ce_debugfs_fops = {
- .owner = THIS_MODULE,
- .open = sun8i_ce_dbgfs_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(sun8i_ce_debugfs);
#endif
static void sun8i_ce_free_chanlist(struct sun8i_ce_dev *ce, int i)
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index fde536469..6fe3e009c 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -263,7 +263,7 @@ static struct sun8i_ss_alg_template ss_algs[] = {
};
#ifdef CONFIG_CRYPTO_DEV_SUN8I_SS_DEBUG
-static int sun8i_ss_dbgfs_read(struct seq_file *seq, void *v)
+static int sun8i_ss_debugfs_show(struct seq_file *seq, void *v)
{
struct sun8i_ss_dev *ss = seq->private;
int i;
@@ -286,18 +286,7 @@ static int sun8i_ss_dbgfs_read(struct seq_file *seq, void *v)
return 0;
}
-static int sun8i_ss_dbgfs_open(struct inode *inode, struct file *file)
-{
- return single_open(file, sun8i_ss_dbgfs_read, inode->i_private);
-}
-
-static const struct file_operations sun8i_ss_debugfs_fops = {
- .owner = THIS_MODULE,
- .open = sun8i_ss_dbgfs_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(sun8i_ss_debugfs);
#endif
static void sun8i_ss_free_flows(struct sun8i_ss_dev *ss, int i)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] crypto: allwinner - Convert to DEFINE_SHOW_ATTRIBUTE
2020-07-16 9:06 [PATCH -next] crypto: allwinner - Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
@ 2020-07-20 12:10 ` Corentin Labbe
0 siblings, 0 replies; 2+ messages in thread
From: Corentin Labbe @ 2020-07-20 12:10 UTC (permalink / raw)
To: Qinglang Miao
Cc: Greg Kroah-Hartman, Maxime Ripard, Chen-Yu Tsai, linux-crypto,
linux-kernel
On Thu, Jul 16, 2020 at 05:06:32PM +0800, Qinglang Miao wrote:
> From: Chen Huang <chenhuang5@huawei.com>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Chen Huang <chenhuang5@huawei.com>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 15 ++-------------
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 15 ++-------------
> 2 files changed, 4 insertions(+), 26 deletions(-)
>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-20 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 9:06 [PATCH -next] crypto: allwinner - Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
2020-07-20 12:10 ` Corentin Labbe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).