From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05217C433E2 for ; Thu, 16 Jul 2020 19:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0CD72076A for ; Thu, 16 Jul 2020 19:12:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lhX4KRZz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729375AbgGPTMw (ORCPT ); Thu, 16 Jul 2020 15:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728374AbgGPTMu (ORCPT ); Thu, 16 Jul 2020 15:12:50 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4684C08C5C0 for ; Thu, 16 Jul 2020 12:12:50 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id m16so4279396pls.5 for ; Thu, 16 Jul 2020 12:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=reZvnOQ8bijPp6S5yQzmCOTTsMLuDmnyX5N/3GfwHXo=; b=lhX4KRZzVkUSda9R6NyorS54yyDn6hPMA24J3zBk96aHpX1ic/PoqYAe/VIB7Xy9B/ HlVJ28tVKHEHHcNCuv/KrJOZBUcoLwz6roC1HJNW31P8tAYmIPcACI0nrMG4j1+ivpMt 1Xfyw0pkzrtmnsj0jd8RERq8Fj7NvEgD8QxLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=reZvnOQ8bijPp6S5yQzmCOTTsMLuDmnyX5N/3GfwHXo=; b=cPrGHasoItzUNrcYz1FKDnvhKcWaJNtXwibImXH/uW6Ef664Us+LAHP2BeSiiqDhrB OkE49tRON+c5AIAkIH5+uApGx4psoUugHoxqjOhFE5oKhjvAqHOgmX56VgSIWgo68wSb g5NAjRcRQRngUS0tfNmSMQ619tHpG1LFrsex+Z3tZYb8vxxs2SprPHUHgtLY+BWKuTWF LA8XpJWXsuLoCxXucSeULHnQCLp5EOGQ6VeL5mmdrYs7F7VObAQHmVk5ze/kW/iun4mz I2wA818hhMOPs6VB8oRFCinzIKbtaHA2zaJZwe3J/UioaQbVIhbw34aXi4YMRQplV674 2hRw== X-Gm-Message-State: AOAM530T0a76lOcSt7haL8e56avTiQEqcLKjM0u3/Uzp/bWw8uI+fVs7 9JGO79foCHJljLawk5bnpBcqGA== X-Google-Smtp-Source: ABdhPJzSOAMegB1OmeJ/PboDzHabSRQP9lhAlD8QVD09gpvRf9fpyvnr8fMJH6cpEeTI0kWvhxJF2g== X-Received: by 2002:a17:902:7441:: with SMTP id e1mr4615121plt.23.1594926769952; Thu, 16 Jul 2020 12:12:49 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g22sm5602957pgb.82.2020.07.16.12.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 12:12:48 -0700 (PDT) Date: Thu, 16 Jul 2020 12:12:47 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Aleksa Sarai , Alexei Starovoitov , Al Viro , Andrew Morton , Andy Lutomirski , Christian Brauner , Christian Heimes , Daniel Borkmann , Deven Bowers , Dmitry Vyukov , Eric Biggers , Eric Chiang , Florian Weimer , James Morris , Jan Kara , Jann Horn , Jonathan Corbet , Lakshmi Ramasubramanian , Matthew Garrett , Matthew Wilcox , Michael Kerrisk , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mimi Zohar , Philippe =?iso-8859-1?Q?Tr=E9buchet?= , Scott Shell , Sean Christopherson , Shuah Khan , Steve Dower , Steve Grubb , Tetsuo Handa , Thibaut Sautereau , Vincent Strubel , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 7/7] ima: add policy support for the new file open MAY_OPENEXEC flag Message-ID: <202007160957.CABE4CC@keescook> References: <20200714181638.45751-1-mic@digikod.net> <20200714181638.45751-8-mic@digikod.net> <202007151339.283D7CD@keescook> <8df69733-0088-3e3c-9c3d-2610414cea2b@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8df69733-0088-3e3c-9c3d-2610414cea2b@digikod.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2020 at 04:40:15PM +0200, Mickaël Salaün wrote: > > On 15/07/2020 22:40, Kees Cook wrote: > > On Tue, Jul 14, 2020 at 08:16:38PM +0200, Mickaël Salaün wrote: > >> From: Mimi Zohar > >> > >> The kernel has no way of differentiating between a file containing data > >> or code being opened by an interpreter. The proposed O_MAYEXEC > >> openat2(2) flag bridges this gap by defining and enabling the > >> MAY_OPENEXEC flag. > >> > >> This patch adds IMA policy support for the new MAY_OPENEXEC flag. > >> > >> Example: > >> measure func=FILE_CHECK mask=^MAY_OPENEXEC > >> appraise func=FILE_CHECK appraise_type=imasig mask=^MAY_OPENEXEC > >> > >> Signed-off-by: Mimi Zohar > >> Reviewed-by: Lakshmi Ramasubramanian > >> Acked-by: Mickaël Salaün > > > > (Process nit: if you're sending this on behalf of another author, then > > this should be Signed-off-by rather than Acked-by.) > > I'm not a co-author of this patch. Correct, but you are part of the delivery path to its entry to the tree. If you were co-author, you would include "Co-developed-by" with a Signed-off-by. (So my nit stands) For excruciating details: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by "The Signed-off-by: tag indicates that the signer was ... in the patch’s delivery path." "Co-developed-by: ... is a used to give attribution to co-authors ..." -- Kees Cook