From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC14C433E3 for ; Thu, 16 Jul 2020 10:43:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 690142074B for ; Thu, 16 Jul 2020 10:43:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HP6p/mT1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727851AbgGPKnX (ORCPT ); Thu, 16 Jul 2020 06:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbgGPKnV (ORCPT ); Thu, 16 Jul 2020 06:43:21 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D385C061755; Thu, 16 Jul 2020 03:43:21 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id d18so4403434edv.6; Thu, 16 Jul 2020 03:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=00KhBJLHsiJghDRk3TFRLtix3PLoiOEqN9E1oKJT9cw=; b=HP6p/mT1v2G3zA0TqjzrAuertSTHWHOaxXVrnW1RcEx1PObu3hCZnKOe3ET4KQ/QBs +C//Qsjnm/zHwu3oNKNI5y2rT/l6KEtJuDpGg5Ht69PgyXtYYnUIjkEu/ph2EOBm2CAh J+4IrbpaX8FzdcEfGf2NUAz7ByFUVuXkfmaEm7AH4LEqj3+QscTZhgDP2TjKMhmFJGoc QKIfd/7MBnd6tIAf2eNZa2+2OJZsq5mSBijuSpXLCR+gMVyZ30SciD65U3oTn9rnk396 W8meQn1U7xVy4s9HsxQ+OUZxrpg+ubb4lINYwImMVQKqcLaZZj0OLp8S6e7g1Y4lIz1s sdJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=00KhBJLHsiJghDRk3TFRLtix3PLoiOEqN9E1oKJT9cw=; b=ubtCuYimGHKgRLEeXRZC1nqedHzD4JbNJWVKOIEcqRO80qAz4m2TwgL2t9z2lnzu9b RywlwoBNFF8PiR2N1nkuiAZYzbtho4PCqa65/dcmUKHdUIF6mWABCJ60aaV3Xly61QJn /acXecBbTd8d+tMiZ7rgFIleVO64bX8g9dgjyKCBBqVUIYWJr2io1fjBR4VjFpnDYvqC mzLA+x40n9gl9rJtfCb+ceSBKkad4MjP/tpFWiaqoXX9NodP49XiNPsKbu+swSgZW1xm DsrqyxmouyTkNdzij5CEyiG2rvlk7hOjlj4kghBsfm/7pxUMFwtxHa6TjsnYw1FKEj8x vGgg== X-Gm-Message-State: AOAM531/jHPHBKXe9rv20+U6LWv0cmLpXs0su3t6WJnXYL6RxBwiLxAr zOhm5SfWQF3jN1DWnES8kPw= X-Google-Smtp-Source: ABdhPJywB3TdDVnjDJMSYwGXiwIDZ0eIh4Lob2BgnaMLvkWP2Y3FTYRBPRvEVFhc1X95TkpZUw91qg== X-Received: by 2002:aa7:dcc8:: with SMTP id w8mr3919135edu.305.1594896199785; Thu, 16 Jul 2020 03:43:19 -0700 (PDT) Received: from BV030612LT ([188.24.137.55]) by smtp.gmail.com with ESMTPSA id bw7sm4790396ejb.5.2020.07.16.03.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 03:43:18 -0700 (PDT) Date: Thu, 16 Jul 2020 13:43:16 +0300 From: Cristian Ciocaltea To: Rob Herring Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: Add bindings for Actions S500 SoC Message-ID: <20200716104316.GA309338@BV030612LT> References: <2a7610ff9f33cf72d9df6fc4598741fb6d7836e0.1593112402.git.cristian.ciocaltea@gmail.com> <20200715200309.GA722435@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200715200309.GA722435@bogus> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15, 2020 at 02:03:09PM -0600, Rob Herring wrote: > On Thu, Jun 25, 2020 at 11:16:18PM +0300, Cristian Ciocaltea wrote: > > Add pinctrl and gpio bindings for Actions Semi S500 SoC. > > > > Signed-off-by: Cristian Ciocaltea > > --- > > .../pinctrl/actions,s500-pinctrl.yaml | 228 ++++++++++++++++++ > > 1 file changed, 228 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > > new file mode 100644 > > index 000000000000..856947c70844 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > > @@ -0,0 +1,228 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pinctrl/actions,s500-pinctrl.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Actions Semi S500 SoC pinmux & GPIO controller > > + > > +maintainers: > > + - Manivannan Sadhasivam > > + > > +description: | > > + Pinmux & GPIO controller manages pin multiplexing & configuration including > > + GPIO function selection & GPIO attributes configuration. Please refer to > > + pinctrl-bindings.txt in this directory for common binding part and usage. > > + > > +properties: > > + compatible: > > + const: actions,s500-pinctrl > > + > > + reg: > > + minItems: 1 > > + maxItems: 4 > > Need to enumerate what each register range is. Hi Rob, Thanks for the review! Would the update below suffice? reg: description: | Specifies the memory region(s) associated with the pin-controller. To improve granularity, up to four register ranges can be provided: * GPIO Output + GPIO Input + GPIO Data * Multiplexing Control * PAD Pull Control + PAD Schmitt Trigger enable + PAD Control * PAD Drive Capacity Select > > + > > + clocks: > > + maxItems: 1 > > + > > + gpio-controller: true > > + > > + gpio-ranges: > > + maxItems: 1 > > + > > + '#gpio-cells': > > + description: > > + Specifies the pin number and flags, as defined in > > + include/dt-bindings/gpio/gpio.h > > + const: 2 > > + > > + interrupt-controller: true > > + > > + '#interrupt-cells': > > + description: > > + Specifies the pin number and flags, as defined in > > + include/dt-bindings/interrupt-controller/irq.h > > + const: 2 > > + > > + interrupts: > > + description: > > + One interrupt per each of the 5 GPIO ports supported by the controller, > > + sorted by port number ascending order. > > + minItems: 5 > > + maxItems: 5 > > + > > +patternProperties: > > + '^.*$': > > + if: > > + type: object > > For a new binding, can you do '-pins$' for the node names so we don't > need this if/then hack. Right, the idea was to be consistent with the existing bindings for S700 and S900, which allow free node names, although they are not yet converted to yaml format. > > + then: > > + patternProperties: > > + 'pinmux$': > > Is this really a pattern? Can't tell from the example. pinmux and pinconf subnodes may appear multiple times, that's why I decided to match their names based on the suffix. The example is not complex enough, I will change it to the following: mmc0_default: mmc0_default { pinmux { groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp", "sd0_cmd_mfp", "sd0_clk_mfp"; function = "sd0"; }; drv_pinconf { groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv"; drive-strength = <8>; }; bias_pinconf { pins = "sd0_d0", "sd0_d1", "sd0_d2", "sd0_d3", "sd0_cmd"; bias-pull-up; }; }; > > + type: object > > + description: > > + Pinctrl node's client devices specify pin muxes using subnodes, > > + which in turn use the standard properties below. > > + $ref: pinmux-node.yaml# > > + > > + properties: > > + groups: > > + description: > > + List of gpio pin groups affected by the functions specified in > > + this subnode. > > + items: > > + oneOf: > > + - enum: [lcd0_d18_mfp, rmii_crs_dv_mfp, rmii_txd0_mfp, > > + rmii_txd1_mfp, rmii_txen_mfp, rmii_rxen_mfp, > > + rmii_rxd1_mfp, rmii_rxd0_mfp, rmii_ref_clk_mfp, > > + i2s_d0_mfp, i2s_pcm1_mfp, i2s0_pcm0_mfp, i2s1_pcm0_mfp, > > + i2s_d1_mfp, ks_in2_mfp, ks_in1_mfp, ks_in0_mfp, > > + ks_in3_mfp, ks_out0_mfp, ks_out1_mfp, ks_out2_mfp, > > + lvds_o_pn_mfp, dsi_dn0_mfp, dsi_dp2_mfp, lcd0_d17_mfp, > > + dsi_dp3_mfp, dsi_dn3_mfp, dsi_dp0_mfp, lvds_ee_pn_mfp, > > + spi0_i2c_pcm_mfp, spi0_i2s_pcm_mfp, dsi_dnp1_cp_mfp, > > + lvds_e_pn_mfp, dsi_dn2_mfp, uart2_rtsb_mfp, > > + uart2_ctsb_mfp, uart3_rtsb_mfp, uart3_ctsb_mfp, > > + sd0_d0_mfp, sd0_d1_mfp, sd0_d2_d3_mfp, sd1_d0_d3_mfp, > > + sd0_cmd_mfp, sd0_clk_mfp, sd1_cmd_mfp, uart0_rx_mfp, > > + clko_25m_mfp, csi_cn_cp_mfp, sens0_ckout_mfp, > > + uart0_tx_mfp, i2c0_mfp, csi_dn_dp_mfp, sen0_pclk_mfp, > > + pcm1_in_mfp, pcm1_clk_mfp, pcm1_sync_mfp, pcm1_out_mfp, > > + dnand_data_wr_mfp, dnand_acle_ce0_mfp, nand_ceb2_mfp, > > + nand_ceb3_mfp] > > + minItems: 1 > > + maxItems: 32 > > + > > + function: > > + description: > > + Specify the alternative function to be configured for the > > + given gpio pin groups. > > + enum: [nor, eth_rmii, eth_smii, spi0, spi1, spi2, spi3, sens0, > > + sens1, uart0, uart1, uart2, uart3, uart4, uart5, uart6, i2s0, > > + i2s1, pcm1, pcm0, ks, jtag, pwm0, pwm1, pwm2, pwm3, pwm4, pwm5, > > + p0, sd0, sd1, sd2, i2c0, i2c1, i2c3, dsi, lvds, usb30, clko_25m, > > + mipi_csi, nand, spdif, ts, lcd0] > > + > > + required: > > + - groups > > + - function > > + > > + additionalProperties: false > > + > > + 'pinconf$': > > + type: object > > + description: > > + Pinctrl node's client devices specify pin configurations using > > + subnodes, which in turn use the standard properties below. > > + $ref: pincfg-node.yaml# > > + > > + properties: > > + groups: > > + description: > > + List of gpio pin groups affected by the drive-strength property > > + specified in this subnode. > > + items: > > + oneOf: > > + - enum: [sirq_drv, rmii_txd01_txen_drv, rmii_rxer_drv, > > + rmii_crs_drv, rmii_rxd10_drv, rmii_ref_clk_drv, > > + smi_mdc_mdio_drv, i2s_d0_drv, i2s_bclk0_drv, i2s3_drv, > > + i2s13_drv, pcm1_drv, ks_in_drv, ks_out_drv, lvds_all_drv, > > + lcd_dsi_drv, dsi_drv, sd0_d0_d3_drv, sd1_d0_d3_drv, > > + sd0_cmd_drv, sd0_clk_drv, sd1_cmd_drv, sd1_clk_drv, > > + spi0_all_drv, uart0_rx_drv, uart0_tx_drv, uart2_all_drv, > > + i2c0_all_drv, i2c12_all_drv, sens0_pclk_drv, > > + sens0_ckout_drv, uart3_all_drv] > > + minItems: 1 > > + maxItems: 32 > > + > > + pins: > > + description: > > + List of gpio pins affected by the bias-pull-* and > > + input-schmitt-* properties specified in this subnode. > > + items: > > + oneOf: > > + - enum: [dnand_dqs, dnand_dqsn, eth_txd0, eth_txd1, eth_txen, > > + eth_rxer, eth_crs_dv, eth_rxd1, eth_rxd0, eth_ref_clk, > > + eth_mdc, eth_mdio, sirq0, sirq1, sirq2, i2s_d0, i2s_bclk0, > > + i2s_lrclk0, i2s_mclk0, i2s_d1, i2s_bclk1, i2s_lrclk1, > > + i2s_mclk1, ks_in0, ks_in1, ks_in2, ks_in3, ks_out0, > > + ks_out1, ks_out2, lvds_oep, lvds_oen, lvds_odp, lvds_odn, > > + lvds_ocp, lvds_ocn, lvds_obp, lvds_obn, lvds_oap, > > + lvds_oan, lvds_eep, lvds_een, lvds_edp, lvds_edn, > > + lvds_ecp, lvds_ecn, lvds_ebp, lvds_ebn, lvds_eap, > > + lvds_ean, lcd0_d18, lcd0_d17, dsi_dp3, dsi_dn3, dsi_dp1, > > + dsi_dn1, dsi_cp, dsi_cn, dsi_dp0, dsi_dn0, dsi_dp2, > > + dsi_dn2, sd0_d0, sd0_d1, sd0_d2, sd0_d3, sd1_d0, sd1_d1, > > + sd1_d2, sd1_d3, sd0_cmd, sd0_clk, sd1_cmd, sd1_clk, > > + spi0_sclk, spi0_ss, spi0_miso, spi0_mosi, uart0_rx, > > + uart0_tx, i2c0_sclk, i2c0_sdata, sensor0_pclk, > > + sensor0_ckout, dnand_ale, dnand_cle, dnand_ceb0, > > + dnand_ceb1, dnand_ceb2, dnand_ceb3, uart2_rx, uart2_tx, > > + uart2_rtsb, uart2_ctsb, uart3_rx, uart3_tx, uart3_rtsb, > > + uart3_ctsb, pcm1_in, pcm1_clk, pcm1_sync, pcm1_out, > > + i2c1_sclk, i2c1_sdata, i2c2_sclk, i2c2_sdata, csi_dn0, > > + csi_dp0, csi_dn1, csi_dp1, csi_dn2, csi_dp2, csi_dn3, > > + csi_dp3, csi_cn, csi_cp, dnand_d0, dnand_d1, dnand_d2, > > + dnand_d3, dnand_d4, dnand_d5, dnand_d6, dnand_d7, > > + dnand_rb, dnand_rdb, dnand_rdbn, dnand_wrb, porb, > > + clko_25m, bsel, pkg0, pkg1, pkg2, pkg3] > > + minItems: 1 > > + maxItems: 64 > > + > > + bias-pull-up: true > > + bias-pull-down: true > > + > > + drive-strength: > > + description: > > + Selects the drive strength for the specified pins, in mA. > > + enum: [2, 4, 8, 12] > > + > > + input-schmitt-enable: true > > + input-schmitt-disable: true > > + > > + additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - gpio-controller > > + - gpio-ranges > > + - '#gpio-cells' > > + - interrupt-controller > > + - '#interrupt-cells' > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + pinctrl: pinctrl@b01b0000 { > > + compatible = "actions,s500-pinctrl"; > > + reg = <0xe01b0000 0x1000>; > > + clocks = <&cmu 20>; > > + gpio-controller; > > + gpio-ranges = <&pinctrl 0 0 132>; > > + #gpio-cells = <2>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupts = , > > + , > > + , > > + , > > + ; > > + > > + i2c0_default: i2c0_default { > > + pinmux { > > + groups = "i2c0_mfp"; > > + function = "i2c0"; > > + }; > > + > > + pinconf { > > + pins = "i2c0_sclk", "i2c0_sdata"; > > + bias-pull-up; > > + }; > > + }; > > + }; > > + > > +... > > -- > > 2.27.0 > >