From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF89C433E2 for ; Thu, 16 Jul 2020 21:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A72D208A7 for ; Thu, 16 Jul 2020 21:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594936042; bh=R1wmezTq7O+jQNI1Y7st2p9vf97tRS9M7P3I2u40jwY=; h=Date:From:To:Cc:Subject:List-ID:From; b=a14tRgztjRPSuGZw9+IRMa6pkNkMvFolTV2YwBBnHzvatVdzcCqVBG7qok+L5l/MH PqppLRjInSe7VqKO2nh7IURccdboJdD9OOVP8kuyZpMTOycpLAPMVBircSoYLsu+Wo gk4J6O1tgnlU2r+50A9WHVwT/kycaWVKVTLsskJM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbgGPVrV (ORCPT ); Thu, 16 Jul 2020 17:47:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:48042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbgGPVrT (ORCPT ); Thu, 16 Jul 2020 17:47:19 -0400 Received: from embeddedor (unknown [201.162.240.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E24C2158C; Thu, 16 Jul 2020 21:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594936038; bh=R1wmezTq7O+jQNI1Y7st2p9vf97tRS9M7P3I2u40jwY=; h=Date:From:To:Cc:Subject:From; b=VJGGIGMWKVzkoeGWZZGF51iN2nkrj/lpyBqVLHPoyxVTQRr4eLqh5PyFrJpUTKLDe xJDD1sH2UwyFzA3Qay6QxpW+Mk2QSQ8DT31BagkCJ66KCt/d2F2PrgEhdp3O4SOmIh Myr0Cd3dukWYUSGr1gNcWAPZfDJXoKhgTHX6KqZM= Date: Thu, 16 Jul 2020 16:52:42 -0500 From: "Gustavo A. R. Silva" To: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery Cc: linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH][next] i2c: aspeed: Use fallthrough pseudo-keyword Message-ID: <20200716215242.GA19193@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva --- drivers/i2c/busses/i2c-aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index f51702d86a90..31268074c422 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c @@ -504,7 +504,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) goto error_and_stop; } irq_handled |= ASPEED_I2CD_INTR_TX_ACK; - /* fall through */ + fallthrough; case ASPEED_I2C_MASTER_TX_FIRST: if (bus->buf_index < msg->len) { bus->master_state = ASPEED_I2C_MASTER_TX; @@ -520,7 +520,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) /* RX may not have completed yet (only address cycle) */ if (!(irq_status & ASPEED_I2CD_INTR_RX_DONE)) goto out_no_complete; - /* fall through */ + fallthrough; case ASPEED_I2C_MASTER_RX: if (unlikely(!(irq_status & ASPEED_I2CD_INTR_RX_DONE))) { dev_err(bus->dev, "master failed to RX\n"); -- 2.27.0