linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: wanghai38@huawei.com
Cc: nico@fluxnic.net, kuba@kernel.org, mst@redhat.com,
	hkallweit1@gmail.com, snelson@pensando.io,
	elfring@users.sourceforge.net, dmitry.torokhov@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	wanghai26@huawei.com
Subject: Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe()
Date: Fri, 17 Jul 2020 12:45:02 -0700 (PDT)	[thread overview]
Message-ID: <20200717.124502.1686970196922612927.davem@davemloft.net> (raw)
In-Reply-To: <20200716035038.19207-1-wanghai38@huawei.com>

From: Wang Hai <wanghai38@huawei.com>
Date: Thu, 16 Jul 2020 11:50:38 +0800

> If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev)
> should be called to free the ndev created earlier. Otherwise, a memleak
> will occur.
> 
> Fixes: 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

Applied, thank you.

      parent reply	other threads:[~2020-07-17 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16  3:50 [PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe() Wang Hai
2020-07-16  6:20 ` Markus Elfring
2020-07-17 19:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717.124502.1686970196922612927.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=elfring@users.sourceforge.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=snelson@pensando.io \
    --cc=wanghai26@huawei.com \
    --cc=wanghai38@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).