linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example
@ 2020-07-03 11:47 Ondrej Jirman
  2020-07-03 11:47 ` [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml Ondrej Jirman
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Ondrej Jirman @ 2020-07-03 11:47 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring, Thierry Reding,
	Sam Ravnborg, Ondrej Jirman, Fabio Estevam, Guido Günther,
	Robert Chiras
  Cc: dri-devel, devicetree, linux-kernel

This patchset fixes warnings in the example in display/bridge/nwl-dsi.yaml
revealed during port of display/panel/rocktech,jh057n00900.yaml to
yaml.

Please take a look.

thank you and regards,
  Ondrej Jirman

Ondrej Jirman (2):
  dt-bindings: display: Fix example in nwl-dsi.yaml
  dt-binding: display: Allow a single port node on rocktech,jh057n00900

 .../devicetree/bindings/display/bridge/nwl-dsi.yaml      | 9 +++++----
 .../bindings/display/panel/rocktech,jh057n00900.yaml     | 1 +
 2 files changed, 6 insertions(+), 4 deletions(-)

-- 
2.27.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml
  2020-07-03 11:47 [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Ondrej Jirman
@ 2020-07-03 11:47 ` Ondrej Jirman
  2020-07-15 21:07   ` Rob Herring
  2020-07-18 16:52   ` Guido Günther
  2020-07-03 11:47 ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Ondrej Jirman
  2020-07-21 15:35 ` [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Rob Herring
  2 siblings, 2 replies; 8+ messages in thread
From: Ondrej Jirman @ 2020-07-03 11:47 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring, Thierry Reding,
	Sam Ravnborg, Ondrej Jirman, Fabio Estevam, Guido Günther,
	Robert Chiras
  Cc: dri-devel, devicetree, linux-kernel

The example is now validated against rocktech,jh057n00900 schema
that was ported to yaml, and didn't validate with:

- '#address-cells', '#size-cells', 'port@0' do not match any of
  the regexes: 'pinctrl-[0-9]+'
- 'vcc-supply' is a required property
- 'iovcc-supply' is a required property
- 'reset-gpios' is a required property

Fix it.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 .../devicetree/bindings/display/bridge/nwl-dsi.yaml      | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
index 8aff2d68fc33..2c4c34e3bc29 100644
--- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
@@ -165,6 +165,7 @@ examples:
  - |
 
    #include <dt-bindings/clock/imx8mq-clock.h>
+   #include <dt-bindings/gpio/gpio.h>
    #include <dt-bindings/interrupt-controller/arm-gic.h>
    #include <dt-bindings/reset/imx8mq-reset.h>
 
@@ -191,12 +192,12 @@ examples:
               phy-names = "dphy";
 
               panel@0 {
-                      #address-cells = <1>;
-                      #size-cells = <0>;
                       compatible = "rocktech,jh057n00900";
                       reg = <0>;
-                      port@0 {
-                           reg = <0>;
+                      vcc-supply = <&reg_2v8_p>;
+                      iovcc-supply = <&reg_1v8_p>;
+                      reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
+                      port {
                            panel_in: endpoint {
                                      remote-endpoint = <&mipi_dsi_out>;
                            };
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900
  2020-07-03 11:47 [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Ondrej Jirman
  2020-07-03 11:47 ` [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml Ondrej Jirman
@ 2020-07-03 11:47 ` Ondrej Jirman
  2020-07-15 21:08   ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech, jh057n00900 Rob Herring
  2020-07-18 16:53   ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Guido Günther
  2020-07-21 15:35 ` [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Rob Herring
  2 siblings, 2 replies; 8+ messages in thread
From: Ondrej Jirman @ 2020-07-03 11:47 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Rob Herring, Thierry Reding,
	Sam Ravnborg, Ondrej Jirman, Fabio Estevam, Guido Günther,
	Robert Chiras
  Cc: dri-devel, devicetree, linux-kernel

The display has one port. Allow it in the binding.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index a6985cd947fb..d5733ef30954 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -24,6 +24,7 @@ properties:
         # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
       - xingbangda,xbd599
 
+  port: true
   reg:
     maxItems: 1
     description: DSI virtual channel
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml
  2020-07-03 11:47 ` [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml Ondrej Jirman
@ 2020-07-15 21:07   ` Rob Herring
  2020-07-18 16:52   ` Guido Günther
  1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-07-15 21:07 UTC (permalink / raw)
  To: Ondrej Jirman
  Cc: Fabio Estevam, Sam Ravnborg, linux-kernel, dri-devel,
	Guido Günther, Daniel Vetter, David Airlie, Rob Herring,
	Robert Chiras, devicetree, Thierry Reding

On Fri, 03 Jul 2020 13:47:16 +0200, Ondrej Jirman wrote:
> The example is now validated against rocktech,jh057n00900 schema
> that was ported to yaml, and didn't validate with:
> 
> - '#address-cells', '#size-cells', 'port@0' do not match any of
>   the regexes: 'pinctrl-[0-9]+'
> - 'vcc-supply' is a required property
> - 'iovcc-supply' is a required property
> - 'reset-gpios' is a required property
> 
> Fix it.
> 
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  .../devicetree/bindings/display/bridge/nwl-dsi.yaml      | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech, jh057n00900
  2020-07-03 11:47 ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Ondrej Jirman
@ 2020-07-15 21:08   ` Rob Herring
  2020-07-18 16:53   ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Guido Günther
  1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-07-15 21:08 UTC (permalink / raw)
  To: Ondrej Jirman
  Cc: Thierry Reding, Fabio Estevam, linux-kernel, devicetree,
	dri-devel, Guido Günther, David Airlie, Sam Ravnborg,
	Daniel Vetter, Robert Chiras, Rob Herring

On Fri, 03 Jul 2020 13:47:17 +0200, Ondrej Jirman wrote:
> The display has one port. Allow it in the binding.
> 
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml  | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml
  2020-07-03 11:47 ` [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml Ondrej Jirman
  2020-07-15 21:07   ` Rob Herring
@ 2020-07-18 16:52   ` Guido Günther
  1 sibling, 0 replies; 8+ messages in thread
From: Guido Günther @ 2020-07-18 16:52 UTC (permalink / raw)
  To: Ondrej Jirman
  Cc: David Airlie, Daniel Vetter, Rob Herring, Thierry Reding,
	Sam Ravnborg, Fabio Estevam, Robert Chiras, dri-devel,
	devicetree, linux-kernel

Hi,
On Fri, Jul 03, 2020 at 01:47:16PM +0200, Ondrej Jirman wrote:
> The example is now validated against rocktech,jh057n00900 schema
> that was ported to yaml, and didn't validate with:
> 
> - '#address-cells', '#size-cells', 'port@0' do not match any of
>   the regexes: 'pinctrl-[0-9]+'
> - 'vcc-supply' is a required property
> - 'iovcc-supply' is a required property
> - 'reset-gpios' is a required property
> 
> Fix it.
> 
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  .../devicetree/bindings/display/bridge/nwl-dsi.yaml      | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> index 8aff2d68fc33..2c4c34e3bc29 100644
> --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> @@ -165,6 +165,7 @@ examples:
>   - |
>  
>     #include <dt-bindings/clock/imx8mq-clock.h>
> +   #include <dt-bindings/gpio/gpio.h>
>     #include <dt-bindings/interrupt-controller/arm-gic.h>
>     #include <dt-bindings/reset/imx8mq-reset.h>
>  
> @@ -191,12 +192,12 @@ examples:
>                phy-names = "dphy";
>  
>                panel@0 {
> -                      #address-cells = <1>;
> -                      #size-cells = <0>;
>                        compatible = "rocktech,jh057n00900";
>                        reg = <0>;
> -                      port@0 {
> -                           reg = <0>;
> +                      vcc-supply = <&reg_2v8_p>;
> +                      iovcc-supply = <&reg_1v8_p>;
> +                      reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
> +                      port {
>                             panel_in: endpoint {
>                                       remote-endpoint = <&mipi_dsi_out>;
>                             };

Reviewed-by: Guido Günther <agx@sigxcpu.org>
 -- Guido

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900
  2020-07-03 11:47 ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Ondrej Jirman
  2020-07-15 21:08   ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech, jh057n00900 Rob Herring
@ 2020-07-18 16:53   ` Guido Günther
  1 sibling, 0 replies; 8+ messages in thread
From: Guido Günther @ 2020-07-18 16:53 UTC (permalink / raw)
  To: Ondrej Jirman
  Cc: David Airlie, Daniel Vetter, Rob Herring, Thierry Reding,
	Sam Ravnborg, Fabio Estevam, Robert Chiras, dri-devel,
	devicetree, linux-kernel

Hi,
On Fri, Jul 03, 2020 at 01:47:17PM +0200, Ondrej Jirman wrote:
> The display has one port. Allow it in the binding.
> 
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml  | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> index a6985cd947fb..d5733ef30954 100644
> --- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
> @@ -24,6 +24,7 @@ properties:
>          # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
>        - xingbangda,xbd599
>  
> +  port: true
>    reg:
>      maxItems: 1
>      description: DSI virtual channel

Reviewed-by: Guido Günther <agx@sigxcpu.org>
 -- Guido

> -- 
> 2.27.0
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example
  2020-07-03 11:47 [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Ondrej Jirman
  2020-07-03 11:47 ` [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml Ondrej Jirman
  2020-07-03 11:47 ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Ondrej Jirman
@ 2020-07-21 15:35 ` Rob Herring
  2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-07-21 15:35 UTC (permalink / raw)
  To: Ondrej Jirman
  Cc: David Airlie, Daniel Vetter, Thierry Reding, Sam Ravnborg,
	Fabio Estevam, Guido Günther, Robert Chiras, dri-devel,
	devicetree, linux-kernel

On Fri, Jul 3, 2020 at 5:47 AM Ondrej Jirman <megous@megous.com> wrote:
>
> This patchset fixes warnings in the example in display/bridge/nwl-dsi.yaml
> revealed during port of display/panel/rocktech,jh057n00900.yaml to
> yaml.
>
> Please take a look.
>
> thank you and regards,
>   Ondrej Jirman
>
> Ondrej Jirman (2):
>   dt-bindings: display: Fix example in nwl-dsi.yaml
>   dt-binding: display: Allow a single port node on rocktech,jh057n00900

Series applied to drm-misc.

Rob

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-07-21 15:35 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03 11:47 [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Ondrej Jirman
2020-07-03 11:47 ` [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml Ondrej Jirman
2020-07-15 21:07   ` Rob Herring
2020-07-18 16:52   ` Guido Günther
2020-07-03 11:47 ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Ondrej Jirman
2020-07-15 21:08   ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech, jh057n00900 Rob Herring
2020-07-18 16:53   ` [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900 Guido Günther
2020-07-21 15:35 ` [PATCH 0/2] Fix warnings in display/bridge/nwl-dsi.yaml DT example Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).