From: Al Viro <viro@zeniv.linux.org.uk>
To: "Xu, Yanfei" <yanfei.xu@windriver.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx
Date: Sun, 19 Jul 2020 17:57:46 +0100 [thread overview]
Message-ID: <20200719165746.GJ2786714@ZenIV.linux.org.uk> (raw)
In-Reply-To: <e3cbdb26-9bfb-55e7-c9a7-deb7f8831754@windriver.com>
On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote:
> ping Al Viro
>
> Could you please help to review this patch? Thanks a lot.
That's -next, right? As for the patch itself... Frankly,
Daniel's patch looks seriously wrong.
* why has O_CLOEXEC been quietly smuggled in? It's
a userland ABI change, for fsck sake...
* the double-put you've spotted
* the whole out: thing - just make it
if (IS_ERR(file)) {
userfaultfd_ctx_put(ctx);
return PTR_ERR(file);
}
and be done with that.
next prev parent reply other threads:[~2020-07-19 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 16:12 [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx yanfei.xu
2020-07-15 1:41 ` Xu, Yanfei
2020-07-19 13:58 ` Xu, Yanfei
2020-07-19 16:57 ` Al Viro [this message]
2020-07-20 1:34 ` Xu, Yanfei
2020-07-22 0:09 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200719165746.GJ2786714@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanfei.xu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).