From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C49CDC433DF for ; Sun, 19 Jul 2020 18:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A725220684 for ; Sun, 19 Jul 2020 18:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595182413; bh=K18LS/3pSq14sLka7mJuVJDiniHhGTMu2W3RqdByp4g=; h=From:To:Cc:Subject:Date:List-ID:From; b=ra+GdcnflyXAgvxP0hXaflJITBmzGaN6MNolpFzvd1+xEPCrS9gmVkgs87dogKbtC 4vAH5LOBUa3ERn6PkndjwgTx6y6BjrOAXVeMPQk4w17vF7+shRhPw/BPjXWDIi3wDl H3g1ifhcYgk/K5nxfnxQRNUxRo5WtWzRDPrLeLiM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726611AbgGSSNc convert rfc822-to-8bit (ORCPT ); Sun, 19 Jul 2020 14:13:32 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22867 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726009AbgGSSNc (ORCPT ); Sun, 19 Jul 2020 14:13:32 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-oHUPqxUTOvKjM4sB-CXu5A-1; Sun, 19 Jul 2020 14:13:26 -0400 X-MC-Unique: oHUPqxUTOvKjM4sB-CXu5A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF8431083; Sun, 19 Jul 2020 18:13:24 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id C784F74F6C; Sun, 19 Jul 2020 18:13:21 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen , Kajol Jain , John Garry , "Paul A. Clarke" , Stephane Eranian , Ian Rogers Subject: [PATCHv3 00/19] perf metric: Add support to reuse metric Date: Sun, 19 Jul 2020 20:13:01 +0200 Message-Id: <20200719181320.785305-1-jolsa@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kernel.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, this patchset is adding the support to reused metric in another metric. For example, to define IPC by using CPI with change like: { "BriefDescription": "Instructions Per Cycle (per Logical Processor)", - "MetricExpr": "INST_RETIRED.ANY / CPU_CLK_UNHALTED.THREAD", + "MetricExpr": "1/CPI", "MetricGroup": "TopDownL1", "MetricName": "IPC" }, I won't be able to find all the possible places we could use this at, so I wonder you guys (who was asking for this) would try it and come up with comments if there's something missing or we could already use it at some places. It's based on Arnaldo's tmp.perf/core. v3 changes: - added some acks - some patches got merged - added missing zalloc include [John Garry] - added ids array outside the egroup object [Ian] - removed wrong m->has_constraint assignment [Ian] - renamed 'list' to 'metric_list' [Ian] - fixed group metric and added test for it [Paul A. Clarke] - fixed memory leak [Arnaldo] - using lowercase keys for metrics in hashmap, because jevents converts metric_expr to lowercase Also available in here: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/metric thanks, jirka --- Jiri Olsa (19): perf metric: Fix memory leak in expr__add_id function perf metric: Add expr__add_id function perf metric: Change expr__get_id to return struct expr_id_data perf metric: Add expr__del_id function perf metric: Add macros for iterating map events perf metric: Add add_metric function perf metric: Rename __metricgroup__add_metric to __add_metric perf metric: Collect referenced metrics in struct metric_ref_node perf metric: Collect referenced metrics in struct metric_expr perf metric: Add referenced metrics to hash data perf metric: Compute referenced metrics perf metric: Add events for the current list perf metric: Add cache_miss_cycles to metric parse test perf metric: Add DCache_L2 to metric parse test perf metric: Add recursion check when processing nested metrics perf metric: Make compute_single function more precise perf metric: Add metric group test perf metric: Rename struct egroup to metric perf metric: Rename group_list to metric_list tools/perf/tests/parse-metric.c | 206 +++++++++++++++++++++++++++++++++++++++++++++++++---- tools/perf/util/expr.c | 143 ++++++++++++++++++++++++++++++++----- tools/perf/util/expr.h | 30 +++++++- tools/perf/util/expr.y | 16 +++-- tools/perf/util/metricgroup.c | 466 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------ tools/perf/util/metricgroup.h | 6 ++ tools/perf/util/stat-shadow.c | 20 ++++-- 7 files changed, 751 insertions(+), 136 deletions(-)