* [PATCH 1/2] staging: rtl8192e: add space before open parenthesis
@ 2020-07-19 12:09 Darshan D V
2020-07-19 12:09 ` [PATCH 2/2] staging: rtl8192e: add proper code indent Darshan D V
2020-07-20 8:22 ` [PATCH 1/2] staging: rtl8192e: add space before open parenthesis Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Darshan D V @ 2020-07-19 12:09 UTC (permalink / raw)
To: gregkh, yuehaibing, ardb, contact; +Cc: devel, linux-kernel, darshandv10
rtllib_crypt_ccmp.c:
Fix the coding style error by adding a space before
open parenthesis '(' in a conditional statement.
Signed-off-by: Darshan D V <darshandv10@gmail.com>
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index 0cbf4a1a326b..b2af802b9451 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
int aad_len, ret;
req = aead_request_alloc(key->tfm, GFP_ATOMIC);
- if(!req)
+ if (!req)
return -ENOMEM;
aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] staging: rtl8192e: add proper code indent
2020-07-19 12:09 [PATCH 1/2] staging: rtl8192e: add space before open parenthesis Darshan D V
@ 2020-07-19 12:09 ` Darshan D V
2020-07-20 8:22 ` [PATCH 1/2] staging: rtl8192e: add space before open parenthesis Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Darshan D V @ 2020-07-19 12:09 UTC (permalink / raw)
To: gregkh, yuehaibing, ardb, contact; +Cc: devel, linux-kernel, darshandv10
rtllib_crypt_ccmp.c:
As the code indent for a conditional statement is
not according to the preferred coding style for
the linux kernel, add code indent as necessary
after a conditional statement.
Signed-off-by: Darshan D V <darshandv10@gmail.com>
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index b2af802b9451..b60e2a109ce4 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
}
if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
- return -1;
+ return -1;
} else if (len == 0) {
data->key_set = 0;
} else {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] staging: rtl8192e: add space before open parenthesis
2020-07-19 12:09 [PATCH 1/2] staging: rtl8192e: add space before open parenthesis Darshan D V
2020-07-19 12:09 ` [PATCH 2/2] staging: rtl8192e: add proper code indent Darshan D V
@ 2020-07-20 8:22 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-07-20 8:22 UTC (permalink / raw)
To: Darshan D V; +Cc: yuehaibing, ardb, contact, devel, linux-kernel
On Sun, Jul 19, 2020 at 05:39:17PM +0530, Darshan D V wrote:
> rtllib_crypt_ccmp.c:
Why is this listed here, with a trailing space? There's no real need
for it, do you see other patches for this file/driver doing that? Try
looking at those for examples of how to properly format changelog texts.
Same thing for your 2/2 patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] staging: rtl8192e: add space before open parenthesis
@ 2020-07-20 9:14 Darshan D V
0 siblings, 0 replies; 4+ messages in thread
From: Darshan D V @ 2020-07-20 9:14 UTC (permalink / raw)
To: gregkh, yuehaibing, ardb, contact; +Cc: devel, linux-kernel, darshandv10
Fix the coding style error by adding a space before
open parenthesis '(' in a conditional statement.
Signed-off-by: Darshan D V <darshandv10@gmail.com>
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index 0cbf4a1a326b..b2af802b9451 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
int aad_len, ret;
req = aead_request_alloc(key->tfm, GFP_ATOMIC);
- if(!req)
+ if (!req)
return -ENOMEM;
aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-20 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-19 12:09 [PATCH 1/2] staging: rtl8192e: add space before open parenthesis Darshan D V
2020-07-19 12:09 ` [PATCH 2/2] staging: rtl8192e: add proper code indent Darshan D V
2020-07-20 8:22 ` [PATCH 1/2] staging: rtl8192e: add space before open parenthesis Greg KH
2020-07-20 9:14 Darshan D V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).