From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF3EC433E4 for ; Mon, 20 Jul 2020 10:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5193E22BF3 for ; Mon, 20 Jul 2020 10:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728383AbgGTKDv (ORCPT ); Mon, 20 Jul 2020 06:03:51 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:57424 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728001AbgGTKDu (ORCPT ); Mon, 20 Jul 2020 06:03:50 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 5F922FB03; Mon, 20 Jul 2020 12:03:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kNNEV4rIAbn4; Mon, 20 Jul 2020 12:03:47 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 9643942576; Mon, 20 Jul 2020 12:03:46 +0200 (CEST) Date: Mon, 20 Jul 2020 12:03:46 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Stefan Agner Cc: Lucas Stach , Marek Vasut , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/mxsfb: Make supported modifiers explicit Message-ID: <20200720100346.GA17641@bogon.m.sigxcpu.org> References: <26877532e272c12a74c33188e2a72abafc9a2e1c.1584973664.git.agx@sigxcpu.org> <20200718171407.GA72952@bogon.m.sigxcpu.org> <427ac44d83e9502afb5a809f28544d6c@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <427ac44d83e9502afb5a809f28544d6c@agner.ch> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jul 20, 2020 at 11:03:04AM +0200, Stefan Agner wrote: > On 2020-07-18 19:14, Guido Günther wrote: > > Hi, > > On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: > >> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther: > >> > In contrast to other display controllers on imx like DCSS and ipuv3 > >> > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts. > >> > Since mesa might assume otherwise make it explicit that only > >> > DRM_FORMAT_MOD_LINEAR is supported. > >> > > >> > Signed-off-by: Guido Günther > >> > >> Reviewed-by: Lucas Stach > > > > Can i do anything to get this applied? > > Cheers, > > -- Guido > > Sorry about the delay, I was thinking to apply it with another patchset > which is not ready though. > > Pushed this patch to drm-misc-next just now. Thanks! -- Guido > > -- > Stefan > > > > >> > >> > --- > >> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++-- > >> > 1 file changed, 7 insertions(+), 2 deletions(-) > >> > > >> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > >> > index 762379530928..fc71e7a7a02e 100644 > >> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > >> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > >> > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = { > >> > DRM_FORMAT_RGB565 > >> > }; > >> > > >> > +static const uint64_t mxsfb_modifiers[] = { > >> > + DRM_FORMAT_MOD_LINEAR, > >> > + DRM_FORMAT_MOD_INVALID > >> > +}; > >> > + > >> > static struct mxsfb_drm_private * > >> > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe) > >> > { > >> > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) > >> > } > >> > > >> > ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs, > >> > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL, > >> > - mxsfb->connector); > >> > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats), > >> > + mxsfb_modifiers, mxsfb->connector); > >> > if (ret < 0) { > >> > dev_err(drm->dev, "Cannot setup simple display pipe\n"); > >> > goto err_vblank; > >> >