From: Stephen Hemminger <stephen@networkplumber.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: "Sriram Krishnan (srirakr2)" <srirakr2@cisco.com>,
Andrew Morton <akpm@linux-foundation.org>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
"Malcolm Bumgardner (mbumgard)" <mbumgard@cisco.com>
Subject: Re: [PATCH v2] AF_PACKET doesnt strip VLAN information
Date: Mon, 20 Jul 2020 13:56:50 -0700 [thread overview]
Message-ID: <20200720135650.1939665b@hermes.lan> (raw)
In-Reply-To: <CAF=yD-+gCkPVkXwcH6KiKYGV77TvpZiDo=3YyXeuGFk=TR2dcw@mail.gmail.com>
On Mon, 20 Jul 2020 09:52:27 -0400
Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
> On Mon, Jul 20, 2020 at 12:27 AM Sriram Krishnan (srirakr2)
> <srirakr2@cisco.com> wrote:
> >
> > +Stephen Hemminger
> >
> > Hi Willem,
> > Thanks for looking into the code, I understand that this is more of a generic problem wherein many of the filtering functions assume the vlan tag to be in the skb rather than in the packet. Hence we moved the fix from the driver to the common AF packet that our solution uses.
> >
> > I recall from the v1 of the patch you had mentioned other common areas where this fix might be relevant (such as tap/tun), but I'm afraid I cant comprehensively test those patches out. Please let me know your thoughts
>
> Please use plain text to respond. HTML replies do not reach the list.
>
> Can you be more precise in which other code besides the hyper-v driver
> is affected? Do you have an example?
>
> This is a resubmit of the original patch. My previous
> questions/concerns remain valid:
>
> - if the function can now fail, all callers must be updated to detect
> and handle that
>
> - any solution should probably address all inputs into the tx path:
> packet sockets, tuntap, virtio-net
>
> - this only addresses packet sockets with ETH_P_ALL/ETH_P_NONE. Not
> sockets that set ETH_P_8021Q
>
> - which code in the transmit stack requires the tag to be in the skb,
> and does this problem after this patch still persist for Q-in-Q?
It matters because the problem is generic, not just to the netvsc driver.
For example, BPF programs and netfilter rules will see different packets
when send is through AF_PACKET than they would see for sends from the
kernel stack.
Presenting uniform data to the lower layers makes sense.
next prev parent reply other threads:[~2020-07-20 20:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 9:17 [PATCH v2] AF_PACKET doesnt strip VLAN information Sriram Krishnan
2020-07-18 15:58 ` Willem de Bruijn
[not found] ` <CY4PR1101MB21013DCD55B754E29AF4A838907B0@CY4PR1101MB2101.namprd11.prod.outlook.com>
2020-07-20 13:52 ` Willem de Bruijn
2020-07-20 17:01 ` Sriram Krishnan (srirakr2)
2020-07-20 20:56 ` Stephen Hemminger [this message]
2020-07-20 21:22 ` Willem de Bruijn
2020-07-20 22:03 ` Stephen Hemminger
2020-07-20 23:36 ` David Miller
2020-07-19 5:16 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720135650.1939665b@hermes.lan \
--to=stephen@networkplumber.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbumgard@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=srirakr2@cisco.com \
--cc=sthemmin@microsoft.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).