From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B911C433EA for ; Mon, 20 Jul 2020 15:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B94C22CAF for ; Mon, 20 Jul 2020 15:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260476; bh=hzLAThHvf7gJmaisKABfV8tEcvLhHCQOlRUK9Pj01rs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=a9bi8Tat96MKrED0PO1rLn3WTpFBKb9YQZel8gQ+55XrN6g10Gh2KWdAfbviWjHPy sSmmkrZXc0gHuqTWVDmjrGo6WAutdYaFUVnC+l6unmFN9qiz164GYB+9XpKty2/+Cr SXZrYzbS6wvvWgTVW/PB3rKUcu3bfu5MCbien2Xg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731581AbgGTPyf (ORCPT ); Mon, 20 Jul 2020 11:54:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:53270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730882AbgGTPyc (ORCPT ); Mon, 20 Jul 2020 11:54:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 356CC206E9; Mon, 20 Jul 2020 15:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260471; bh=hzLAThHvf7gJmaisKABfV8tEcvLhHCQOlRUK9Pj01rs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XvR8g8kwh5p/2JZI80ofs9nBkVhG7cR7vmTPmazcd/F5hgEKlb0nPdP9zupOBtWPq hy3VjN9VapGauFtp4sPR1IPkqoP5VVhJbYpqWcLQzkw2vpH5lP/8ErX6z7F2MbRsr4 0/98v8Ww2JnbEcu8XqAyC3bjG8D8yMECgy0cfs88= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vishwas M , Guenter Roeck Subject: [PATCH 4.19 115/133] hwmon: (emc2103) fix unable to change fan pwm1_enable attribute Date: Mon, 20 Jul 2020 17:37:42 +0200 Message-Id: <20200720152809.293848071@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152803.732195882@linuxfoundation.org> References: <20200720152803.732195882@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vishwas M commit 14b0e83dc4f1e52b94acaeb85a18fd7fdd46d2dc upstream. This patch fixes a bug which does not let FAN mode to be changed from sysfs(pwm1_enable). i.e pwm1_enable can not be set to 3, it will always remain at 0. This is caused because the device driver handles the result of "read_u8_from_i2c(client, REG_FAN_CONF1, &conf_reg)" incorrectly. The driver thinks an error has occurred if the (result != 0). This has been fixed by changing the condition to (result < 0). Signed-off-by: Vishwas M Link: https://lore.kernel.org/r/20200707142747.118414-1-vishwas.reddy.vr@gmail.com Fixes: 9df7305b5a86 ("hwmon: Add driver for SMSC EMC2103 temperature monitor and fan controller") Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/emc2103.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hwmon/emc2103.c +++ b/drivers/hwmon/emc2103.c @@ -454,7 +454,7 @@ static ssize_t pwm1_enable_store(struct } result = read_u8_from_i2c(client, REG_FAN_CONF1, &conf_reg); - if (result) { + if (result < 0) { count = result; goto err; }