From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BCBC433ED for ; Mon, 20 Jul 2020 16:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28D562065E for ; Mon, 20 Jul 2020 16:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261163; bh=QIm44/wTMe9SHCVtW0oHtKyjaHbvM44SY6l+RDxCghc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GqPow57PF7joCYKc1SYVjYQdFAYxxuS6Id9pNbOtBmGDaoDezjJ0vn08Pp6u22zzK m2BthkSIAePtIuUM8GgQ4A8/fmQm5zsy4ktlUofPvt1uyHk6ZBd4KRpcjhMVj3qWDS penI/AAxLsu5jXY/CQMumio/Y/9dmBOruRdDkA7o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733029AbgGTQGB (ORCPT ); Mon, 20 Jul 2020 12:06:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:41776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733012AbgGTQFy (ORCPT ); Mon, 20 Jul 2020 12:05:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 876652064B; Mon, 20 Jul 2020 16:05:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261154; bh=QIm44/wTMe9SHCVtW0oHtKyjaHbvM44SY6l+RDxCghc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hlkYSQMtL6mXwedZj5OREtnDR2aMZ4oN30/HAvlr2XqYpxSP0LS+bEjas6LzAmytQ SUoPIETW19yw17zLJzVwy1UFVUK39i0hsaVwNESnVXtqrHwPrq+v/rx/Jb/2XaH78S 7V+Bk808dpljmMONMEn2YUZqDBj9zX5+UfNPZY7E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, thomas.gambier@nexedi.com, David Ahern , "David S. Miller" Subject: [PATCH 5.7 005/244] ipv6: Fix use of anycast address with loopback Date: Mon, 20 Jul 2020 17:34:36 +0200 Message-Id: <20200720152826.126487550@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152825.863040590@linuxfoundation.org> References: <20200720152825.863040590@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Ahern [ Upstream commit aea23c323d89836bcdcee67e49def997ffca043b ] Thomas reported a regression with IPv6 and anycast using the following reproducer: echo 1 > /proc/sys/net/ipv6/conf/all/forwarding ip -6 a add fc12::1/16 dev lo sleep 2 echo "pinging lo" ping6 -c 2 fc12:: The conversion of addrconf_f6i_alloc to use ip6_route_info_create missed the use of fib6_is_reject which checks addresses added to the loopback interface and sets the REJECT flag as needed. Update fib6_is_reject for loopback checks to handle RTF_ANYCAST addresses. Fixes: c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use ip6_route_info_create") Reported-by: thomas.gambier@nexedi.com Signed-off-by: David Ahern Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -3402,7 +3402,7 @@ static bool fib6_is_reject(u32 flags, st if ((flags & RTF_REJECT) || (dev && (dev->flags & IFF_LOOPBACK) && !(addr_type & IPV6_ADDR_LOOPBACK) && - !(flags & RTF_LOCAL))) + !(flags & (RTF_ANYCAST | RTF_LOCAL)))) return true; return false;