From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63A4C3F2FE for ; Mon, 20 Jul 2020 21:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4C47206E9 for ; Mon, 20 Jul 2020 21:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595281345; bh=xAwsdarEG2CBrklf9ot9VZhvrow2vneesuNuCyiKZP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vYuTA0/OFhjK3iCiqe6E+INMeXg75+VP3pMkRP7f9DCr5CmCJow6CiUQT1xjuo2/c NXbjPaP34ul/0blMPCzYI6M7KA6UcvK5izlAp2UcGqs/KGgrw1p7exJyv1R2slWMwO 9SVTZRYaYqmg+dNeS2H5l4jZbXbgOfvzwV77kPBY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbgGTVmX (ORCPT ); Mon, 20 Jul 2020 17:42:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:58084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728313AbgGTVjB (ORCPT ); Mon, 20 Jul 2020 17:39:01 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C20D320717; Mon, 20 Jul 2020 21:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595281141; bh=xAwsdarEG2CBrklf9ot9VZhvrow2vneesuNuCyiKZP4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jAfB7vgJ4toTGZLo9zMtVEa883YHkGjWfd7vNOeKaYMymNBItMRp6z5xntg/IZKIg x1fe22YSJAB1mCAIUFvb71l1h0ALspyKr9DHtvl8jkVnwzqE/Q+CrDctEekRUMjmNC SBCqd6nl97t9irv3LiaWeP/sT9j4eqI78Jfb1/28= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Marc Kleine-Budde , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.19 08/19] regmap: dev_get_regmap_match(): fix string comparison Date: Mon, 20 Jul 2020 17:38:39 -0400 Message-Id: <20200720213851.407715-8-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200720213851.407715-1-sashal@kernel.org> References: <20200720213851.407715-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marc Kleine-Budde [ Upstream commit e84861fec32dee8a2e62bbaa52cded6b05a2a456 ] This function is used by dev_get_regmap() to retrieve a regmap for the specified device. If the device has more than one regmap, the name parameter can be used to specify one. The code here uses a pointer comparison to check for equal strings. This however will probably always fail, as the regmap->name is allocated via kstrdup_const() from the regmap's config->name. Fix this by using strcmp() instead. Signed-off-by: Marc Kleine-Budde Link: https://lore.kernel.org/r/20200703103315.267996-1-mkl@pengutronix.de Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/base/regmap/regmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index c7d946b745efe..d26b485ccc7d0 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1343,7 +1343,7 @@ static int dev_get_regmap_match(struct device *dev, void *res, void *data) /* If the user didn't specify a name match any */ if (data) - return (*r)->name == data; + return !strcmp((*r)->name, data); else return 1; } -- 2.25.1