From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC28EC433E2 for ; Tue, 21 Jul 2020 08:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C20120792 for ; Tue, 21 Jul 2020 08:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595319593; bh=G1ZJ6z2nGN2ypA8j/rBMCiv4O5LEWR6lDslIJVYhYWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KQhh0SFFgaavZv06fq/x7b3eYRVwENDGOI+zEbeL8ZJ9xu8aOAM7OnEEtrXJET4a8 t1M8kb0HtSKBuet1+PSHPpCZAk6w4y3QnyQCLliGXTsMnkR984V/ILQ7PxB6Cpuu+Q UVL2PhKItHCeIVzxmYIhe/sP+9NB3BqBfVnCHNn8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728777AbgGUITw (ORCPT ); Tue, 21 Jul 2020 04:19:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:44664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728352AbgGUITw (ORCPT ); Tue, 21 Jul 2020 04:19:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 603242068F; Tue, 21 Jul 2020 08:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595319591; bh=G1ZJ6z2nGN2ypA8j/rBMCiv4O5LEWR6lDslIJVYhYWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D+hWS8vl0/WJjxnt0isHR923FpV6OUrI0ho4z6Nb3XRVPPqcUKDjSjFooek4rHmK5 R7Td12WPySgXr5gQaBRZgEa22cTriuWcVngV/eEP7E+7wOHKLgsxylF0/bMk0seB0G djr8tESJw3LiehUeyGJpEaBlJwxcSTy4X7AXuBJU= Date: Tue, 21 Jul 2020 10:20:00 +0200 From: Greg KH To: Qiwu Huang Cc: sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com, Qiwu Huang Subject: Re: [PATCH v5 3/4] power: supply: core: add wireless signal strength property Message-ID: <20200721082000.GD1655283@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 01:59:36PM +0800, Qiwu Huang wrote: > From: Qiwu Huang > > reports wireless signal strength. > The value show degree of coupling between tx and rx. > > Signed-off-by: Qiwu Huang > --- > Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++ > drivers/power/supply/power_supply_sysfs.c | 1 + > include/linux/power_supply.h | 1 + > 3 files changed, 12 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index 03ab449fae8a..75ec7de2fe78 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -757,3 +757,13 @@ Description: > 13: ADAPTER_VOICE_BOX, > 14: ADAPTER_PRIVATE_PD_50W. > > +What: /sys/class/power_supply//signal_strength > +Date: Jul 2020 > +Contact: Fei Jiang > +Description: > + In PING phase, RX transmits a signal strength packet as the first What does "PING phase" mean? Other than that, seems sane to me, thanks for the changes. Reviewed-by: Greg Kroah-Hartman