From: Greg KH <gregkh@linuxfoundation.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: applicom: remove set but not used variable 'byte_reset_it'
Date: Tue, 21 Jul 2020 10:54:41 +0200 [thread overview]
Message-ID: <20200721085441.GB1664942@kroah.com> (raw)
In-Reply-To: <20200721084107.13472-1-zhengyongjun3@huawei.com>
On Tue, Jul 21, 2020 at 04:41:07PM +0800, Zheng Yongjun wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/char/applicom.c: In function 'ac_register_board':
> drivers/char/applicom.c:543: warning:
> variable 'byte_reset_it' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/char/applicom.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
> index 14b2d8034c51..fd0b21607a7f 100644
> --- a/drivers/char/applicom.c
> +++ b/drivers/char/applicom.c
> @@ -131,8 +131,6 @@ static int dummy; /* dev_id for request_irq() */
> static int ac_register_board(unsigned long physloc, void __iomem *loc,
> unsigned char boardno)
> {
> - volatile unsigned char byte_reset_it;
> -
> if((readb(loc + CONF_END_TEST) != 0x00) ||
> (readb(loc + CONF_END_TEST + 1) != 0x55) ||
> (readb(loc + CONF_END_TEST + 2) != 0xAA) ||
> @@ -160,7 +158,6 @@ static int ac_register_board(unsigned long physloc, void __iomem *loc,
> apbs[boardno].RamIO = loc;
> init_waitqueue_head(&apbs[boardno].FlagSleepSend);
> spin_lock_init(&apbs[boardno].mutex);
> - byte_reset_it = readb(loc + RAM_IT_TO_PC);
Are you sure you didn't just break the driver? Lots of times reading
from hardware is required in order to have previous things work, or even
have other affects.
thanks,
greg k-h
prev parent reply other threads:[~2020-07-21 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 8:41 [PATCH] drivers: applicom: remove set but not used variable 'byte_reset_it' Zheng Yongjun
2020-07-21 8:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721085441.GB1664942@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).