From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387B7C433E2 for ; Tue, 21 Jul 2020 19:21:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1778320717 for ; Tue, 21 Jul 2020 19:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595359292; bh=uvcuFv0R6bqByYEk1y2UFO10PzRWHHXQclqrGDwva6Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=r2EunrfD+qMicerByom6aDpNSiciBqu9X2W5cP8sPF5YooEPu6tlVdsKk7m8bQcym V/wj+vSvYK7M2ecFYg7WvU6iTDGFaIYFlna0LsDtq795o85+oy51/IVkoC1CqVrKsh Tz9ZIxoYwd37yc0X3Dz8qlD/wUvUKDKyBF+AnuaU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730684AbgGUTVa (ORCPT ); Tue, 21 Jul 2020 15:21:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:58888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730250AbgGUTVa (ORCPT ); Tue, 21 Jul 2020 15:21:30 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F3B1206F2; Tue, 21 Jul 2020 19:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595359289; bh=uvcuFv0R6bqByYEk1y2UFO10PzRWHHXQclqrGDwva6Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t7QKyQb8s6wv3ahZjUOMbWYGDUR3vmzeNZrTzR5ncfMPPccXMI0Ij9jPtgbZbnV78 1T93wL1AeCGIZG8zN3KHjcoJ3HZMiGNyGyZgq+7LGuAVVh64iru1o+VYnASx+jYyIu aFHGOelzKORJ61nNURYKYwZHH/Bx0uW2vn6M3OLc= Date: Tue, 21 Jul 2020 12:21:27 -0700 From: Jakub Kicinski To: Chi Song Cc: Stephen Hemminger , David Miller , Haiyang Zhang , KY Srinivasan , Stephen Hemminger , "wei.liu@kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table Message-ID: <20200721122127.3ce422f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jul 2020 04:58:59 +0000 Chi Song wrote: > An imbalanced TX indirection table causes netvsc to have low > performance. This table is created and managed during runtime. To help > better diagnose performance issues caused by imbalanced tables, add > device attributes to show the content of TX indirection tables. > > Signed-off-by: Chi Song Sorry for waiting until v6 but sysfs feel like a very strange place to expose this. Especially under the netdev, not the bus device. This looks like device specific state, perhaps ethtool -d is a more appropriate place?