From: Steven Rostedt <rostedt@goodmis.org>
To: Tingwei Zhang <tingwei@codeaurora.org>
Cc: Ingo Molnar <mingo@redhat.com>,
tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Mao Jinlong <jinlmao@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] tracing: add trace_export support for event trace
Date: Tue, 21 Jul 2020 12:37:33 -0400 [thread overview]
Message-ID: <20200721123733.1a87568a@oasis.local.home> (raw)
In-Reply-To: <20200720022117.9375-3-tingwei@codeaurora.org>
On Mon, 20 Jul 2020 10:21:15 +0800
Tingwei Zhang <tingwei@codeaurora.org> wrote:
> Only function traces can be exported to other destinations currently.
> This patch exports event trace as well.
>
> Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
> ---
> kernel/trace/trace.c | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index bb62269724d5..aef6330836e2 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2697,17 +2697,6 @@ int tracepoint_printk_sysctl(struct ctl_table *table, int write,
> return ret;
> }
>
> -void trace_event_buffer_commit(struct trace_event_buffer *fbuffer)
> -{
> - if (static_key_false(&tracepoint_printk_key.key))
> - output_printk(fbuffer);
> -
> - event_trigger_unlock_commit_regs(fbuffer->trace_file, fbuffer->buffer,
> - fbuffer->event, fbuffer->entry,
> - fbuffer->flags, fbuffer->pc, fbuffer->regs);
> -}
> -EXPORT_SYMBOL_GPL(trace_event_buffer_commit);
> -
Please move the ftrace_exports routines up, instead of moving the
trace_event_buffer_commit() down. As it fits better where it is (next
to the other buffer_commit code).
-- Steve
> /*
> * Skip 3:
> *
> @@ -2868,6 +2857,19 @@ int unregister_ftrace_export(struct
> trace_export *export) }
> EXPORT_SYMBOL_GPL(unregister_ftrace_export);
>
> +void trace_event_buffer_commit(struct trace_event_buffer *fbuffer)
> +{
> + if (static_key_false(&tracepoint_printk_key.key))
> + output_printk(fbuffer);
> +
> + if (static_branch_unlikely(&ftrace_exports_enabled))
> + ftrace_exports(fbuffer->event);
> + event_trigger_unlock_commit_regs(fbuffer->trace_file,
> fbuffer->buffer,
> + fbuffer->event, fbuffer->entry,
> + fbuffer->flags, fbuffer->pc,
> fbuffer->regs); +}
> +EXPORT_SYMBOL_GPL(trace_event_buffer_commit);
> +
> void
> trace_function(struct trace_array *tr,
> unsigned long ip, unsigned long parent_ip, unsigned
> long flags,
next prev parent reply other threads:[~2020-07-21 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 2:21 [PATCH 0/4] tracing: export event trace and trace_marker Tingwei Zhang
2020-07-20 2:21 ` [PATCH 1/4] stm class: ftrace: change dependency to TRACING Tingwei Zhang
2020-07-20 2:21 ` [PATCH 2/4] tracing: add trace_export support for event trace Tingwei Zhang
2020-07-21 16:37 ` Steven Rostedt [this message]
2020-07-21 16:43 ` Steven Rostedt
2020-07-21 23:54 ` tingwei
2020-07-21 23:36 ` tingwei
2020-07-20 2:21 ` [PATCH 3/4] tracing: add trace_export support for trace_marker Tingwei Zhang
2020-07-20 2:21 ` [PATCH 4/4] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-07-21 17:55 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721123733.1a87568a@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jinlmao@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).